Filip/matrix-spec
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-spec synced 2025-12-30 12:38:38 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

We sign the request body, not the JSON

Browse source 
when signing federation requests, we put the actual request body into the
canonicaljson to be signed, not the JSON representation of it.
This commit is contained in:
Richard van der Hoff 2017-12-10 22:51:49 +00:00
parent 0a540bf544
commit 08d137a588
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
specification/server_server_api.rst
View file

@ -1174,7 +1174,7 @@ Step 1 sign JSON:
"uri": "/target",
"origin": "origin.hs.example.com",
"destintation": "destination.hs.example.com",
"content": { JSON content ... },
"content": <request body>,
"signatures": {
"origin.hs.example.com": {
"ed25519:key1": "ABCDEF..."
@ -1190,7 +1190,7 @@ Step 2 add Authorization header:
Authorization: X-Matrix origin=origin.example.com,key="ed25519:key1",sig="ABCDEF..."
Content-Type: application/json
{ JSON content ... }
<JSON-encoded request body>
Example python code:
@ -1199,7 +1199,7 @@ Example python code:
def authorization_headers(origin_name, origin_signing_key,
destination_name, request_method, request_target,
content_json=None):
content=None):
request_json = {
"method": request_method,
"uri": request_target,
@ -1208,7 +1208,7 @@ Example python code:
}
if content_json is not None:
request["content"] = content_json
request["content"] = content
signed_json = sign_json(request_json, origin_name, origin_signing_key)