From 1a69a5142dbf46988cd37b56279a824177331720 Mon Sep 17 00:00:00 2001 From: Srinjoy Sen Chowdhury <116475469+AllMightLegend@users.noreply.github.com> Date: Tue, 13 Aug 2024 22:43:38 +0530 Subject: [PATCH] Update 1250.feature --- changelogs/application_service/newsfragments/1250.feature | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/changelogs/application_service/newsfragments/1250.feature b/changelogs/application_service/newsfragments/1250.feature index e3040980..5a8958d3 100644 --- a/changelogs/application_service/newsfragments/1250.feature +++ b/changelogs/application_service/newsfragments/1250.feature @@ -1,18 +1,21 @@ Issue 1250 fixed : allowed {as,hs}_token to be specified as {as,hs_token_path} instead in registration.yaml Implementation Notes: + Token Handling Logic: The application should first check if the *_token_path fields are set. If they are, it should read the token from the specified file, strip any leading/trailing whitespace, and use it as the token. If the *_token_path fields are not set, the application should fall back to using the *_token fields. + Security Considerations: Ensure that the files containing the tokens have appropriate file permissions to prevent unauthorized access. The application should handle potential errors such as file not found, permission denied, or empty token file gracefully. + Backward Compatibility: This change is backward-compatible as it allows the use of either the direct token value (as_token/hs_token) or the path-based approach (as_token_path/hs_token_path). Special Note : Also if we're allowing the use of either the direct token (as_token/hs_token) or the path-based token (as_token_path/hs_token_path), then neither - as_token nor hs_token should be marked as strictly required on their own in the required container. \ No newline at end of file + as_token nor hs_token should be marked as strictly required on their own in the required container.