Filip/matrix-spec
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-spec synced 2026-03-29 15:34:09 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix changed-in partial when used with multiple paragraphs

Browse source 
When used with a text that includes multiple paragraphs, the partial created invalid HTML by nesting `<p>` elements.
It also changed the rendering by making "Changed in vX.XX:" a separate paragraph, when it is inline with a single paragraph.

To change that we do as with "Required" and add "Changed in vX.XX:" to the text before it is rendered, making it inline with the first paragraph.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
This commit is contained in:
Kévin Commaille 2024-11-19 12:01:14 +01:00
parent c5d7eb7a2d
commit 2ecebb1ae8
No known key found for this signature in database
GPG key ID: 0C971D9DBC9D678D
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
layouts/partials/changed-in.html
View file

@ -1,15 +1,11 @@
{{/* {{- /*
Renders the "Changed in [version]:" blocks for x-changedInMatrixVersion Renders the "Changed in [version]:" blocks for x-changedInMatrixVersion
annotations for openapi parameters annotations for openapi parameters
Takes a single 'changes_dict' parameter, which should be a map of Takes a single 'changes_dict' parameter, which should be a map of
version -> details pairs. version -> details pairs.
*/ -}} */ -}}
{{ range $ver, $details := .changes_dict -}} {{- range $ver, $details := .changes_dict -}}
<p> {{- $details = printf "**Changed in `v%s`:** %s" $ver (default "" $details) -}}
<strong> {{- $details | page.RenderString (dict "display" "block") -}}
Changed in <code>v{{ $ver }}</code>:
</strong>
{{ $details | markdownify }}
</p>
{{ end -}} {{ end -}}