Apply suggestions from code review

Signed-off-by: tusooa <tusooa@kazv.moe>

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
This commit is contained in:
No. 2026-06-24 00:28:53 -04:00 committed by GitHub
parent 46edc59097
commit 37f1536532
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions

View file

@ -1 +1 @@
Fix logic error in validation of incoming olm-encrypted messages Correct some errors in the description of the validation process for incoming Olm-encrypted messages.

View file

@ -1662,6 +1662,7 @@ of olm sessions maintained per device should be at least 4.
###### Validation of incoming decrypted events ###### Validation of incoming decrypted events
{{% changed-in v="1.15" %}} Existing checks made more explicit, and checks for `sender_device_keys` added. {{% changed-in v="1.15" %}} Existing checks made more explicit, and checks for `sender_device_keys` added.
{{% changed-in v="1.19" %}} Corrections to some errors in the description of the verification checks.
After decrypting an incoming encrypted event, clients MUST apply the After decrypting an incoming encrypted event, clients MUST apply the
following checks: following checks:
@ -1679,7 +1680,7 @@ following checks:
5. Where `sender_device_keys` is present in the decrypted content: 5. Where `sender_device_keys` is present in the decrypted content:
1. `sender_device_keys.user_id` must also match the `sender` 1. `sender_device_keys.user_id` must also match the `sender`
of the event. of the event.
2. `sender_device_keys.keys.curve25519:<device_id>` must also match 2. `sender_device_keys.keys.curve25519:<device_id>` must match
the `sender_key` property in the cleartext `m.room.encrypted` the `sender_key` property in the cleartext `m.room.encrypted`
event body. event body.
3. `sender_device_keys.keys.ed25519:<device_id>` must be the same 3. `sender_device_keys.keys.ed25519:<device_id>` must be the same