Enforce additionalProperties: {} instead of the equivalent additionalProperties: true for easier processing

changelogs/internal/newsfragments/1909.clarification

@@ -1 +1 @@
-Treat `additionalProperties: true` equivalent to `additionalProperties: {}` when rendering object tables.
+Enforce `additionalProperties: {}` instead of the equivalent `additionalProperties: true` for easier processing.

data/api/client-server/definitions/user_identifier.yaml

@@ -21,4 +21,4 @@ properties:
     description: The type of identification.  See [Identifier types](/client-server-api/#identifier-types) for supported values and additional property descriptions.
 required:
   - type
-additionalProperties: true
+additionalProperties: {}

layouts/partials/openapi/render-object-table.html

@@ -68,17 +68,16 @@
       TODO: support `patternProperties` here.
     */}}
 
-    {{/* Map `additionalProperties: true` to the equivalent `additionalProperties: {}` */}}
+    {{/* Enforce `additionalProperties: {}` instead of the equivalent `additionalProperties: true` for easier processing */}}
-    {{ $additionalProperties := .additionalProperties }}
+    {{ if eq .additionalProperties true }}
-    {{ if eq $additionalProperties true }}
+      {{ errorf "Use `additionalProperties: {}` instead of `additionalProperties: true`" }}
-      {{ $additionalProperties = dict }}
     {{ end }}
 
-    {{ if reflect.IsMap $additionalProperties }}
+    {{ if reflect.IsMap .additionalProperties }}
  <tr>
   <td>&lt;Other properties&gt;</td>
-  <td><code>{{ partial "partials/property-type" $additionalProperties | safeHTML }}</code></td>
+  <td><code>{{ partial "partials/property-type" .additionalProperties | safeHTML }}</code></td>
-  <td>{{ partial "partials/property-description" (dict "property" $additionalProperties) }}</td>
+  <td>{{ partial "partials/property-description" (dict "property" .additionalProperties) }}</td>
  </tr>
     {{ end }}
 </table>