From 86396b46b86e099d1b4062b7f2bb2a3c9eddb24e Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Date: Wed, 17 Jun 2026 09:19:41 +0100
Subject: [PATCH] Fix extension check in check-newsfragments (#2402)

This was added in #1542, but has never worked correctly: it failed to
set the exit code if an incorrectly-named newsfragment was found.
---
 .../newsfragments/{2351.misc => 2351.clarification}              | 0
 .../newsfragments/{2351.misc => 2351.clarification}              | 0
 changelogs/internal/newsfragments/2402.clarification             | 1 +
 .../newsfragments/{2351.misc => 2351.clarification}              | 0
 .../newsfragments/{2351.misc => 2351.clarification}              | 0
 scripts/check-newsfragments                                      | 1 +
 6 files changed, 2 insertions(+)
 rename changelogs/application_service/newsfragments/{2351.misc => 2351.clarification} (100%)
 rename changelogs/client_server/newsfragments/{2351.misc => 2351.clarification} (100%)
 create mode 100644 changelogs/internal/newsfragments/2402.clarification
 rename changelogs/room_versions/newsfragments/{2351.misc => 2351.clarification} (100%)
 rename changelogs/server_server/newsfragments/{2351.misc => 2351.clarification} (100%)

diff --git a/changelogs/application_service/newsfragments/2351.misc b/changelogs/application_service/newsfragments/2351.clarification
similarity index 100%
rename from changelogs/application_service/newsfragments/2351.misc
rename to changelogs/application_service/newsfragments/2351.clarification
diff --git a/changelogs/client_server/newsfragments/2351.misc b/changelogs/client_server/newsfragments/2351.clarification
similarity index 100%
rename from changelogs/client_server/newsfragments/2351.misc
rename to changelogs/client_server/newsfragments/2351.clarification
diff --git a/changelogs/internal/newsfragments/2402.clarification b/changelogs/internal/newsfragments/2402.clarification
new file mode 100644
index 00000000..4dc571f2
--- /dev/null
+++ b/changelogs/internal/newsfragments/2402.clarification
@@ -0,0 +1 @@
+Minor fixes to `check-newsfragments` CI script.
diff --git a/changelogs/room_versions/newsfragments/2351.misc b/changelogs/room_versions/newsfragments/2351.clarification
similarity index 100%
rename from changelogs/room_versions/newsfragments/2351.misc
rename to changelogs/room_versions/newsfragments/2351.clarification
diff --git a/changelogs/server_server/newsfragments/2351.misc b/changelogs/server_server/newsfragments/2351.clarification
similarity index 100%
rename from changelogs/server_server/newsfragments/2351.misc
rename to changelogs/server_server/newsfragments/2351.clarification
diff --git a/scripts/check-newsfragments b/scripts/check-newsfragments
index 242b46d8..995a3282 100755
--- a/scripts/check-newsfragments
+++ b/scripts/check-newsfragments
@@ -26,6 +26,7 @@ while read f; do
     # check that each changelog file has a known extension
     if ! [[ "$extension" == "new" || "$extension" == "feature" || "$extension" == "clarification" || "$extension" == "breaking" || "$extension" == "deprecation" ]]; then
         echo -e "\e[31mERROR: newsfragment $f does not have one of the required file extensions for a changelog entry: .new, .feature, .clarification, .breaking, .deprecation\e[39m" >&2
+        failed=1
     fi
 
     # check that there is nothing that looks like a newsfile outside one of the