Filip/matrix-spec
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-spec synced 2026-04-30 14:14:09 +02:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Address review comments

Browse source
This commit is contained in:
Richard van der Hoff 2023-02-28 14:19:51 +00:00
parent 3ec3737a47
commit 97b7544f2c
2 changed files with 15 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/client_server/newsfragments/1440.feature
View file

@ -1 +1 @@
Changes to the server-side aggregation of `m.replace` (edit) events, per [MSC3925](https://github.com/matrix-org/matrix-spec-proposals/pull/3925). Changes to the server-side aggregation of `m.replace` (edit) events, as per [MSC3925](https://github.com/matrix-org/matrix-spec-proposals/pull/3925).

24
content/client-server-api/modules/event_replacements.md
View file

@ -188,12 +188,14 @@ replacement event.
##### Server-side aggregation of `m.replace` relationships ##### Server-side aggregation of `m.replace` relationships
{{< changed-in v="1.7" >}}
Note that there can be multiple events with an `m.replace` relationship to a Note that there can be multiple events with an `m.replace` relationship to a
given event (for example, if an event is edited multiple times). These should given event (for example, if an event is edited multiple times). These should
be [aggregated](#aggregations) by the homeserver. be [aggregated](#aggregations) by the homeserver.
The aggregation format of `m.replace` relationships gives the **most recent** The aggregation format of `m.replace` relationships gives the **most recent**
replacement event, formatted as normal for the client-server API (see [Room Event Format](#room-event-format)). replacement event, formatted as normal (see [Room Event Format](#room-event-format)).
The most recent event is determined by comparing `origin_server_ts`; if two or The most recent event is determined by comparing `origin_server_ts`; if two or
more replacement events have identical `origin_server_ts`, the event with the more replacement events have identical `origin_server_ts`, the event with the
@ -237,21 +239,23 @@ event that is the target of an `m.replace` relationship. For example:
} }
``` ```
If the original event is If the original event is [redacted](#redactions), any
[redacted](#redactions), any
`m.replace` relationship should **not** be bundled with it (whether or not any `m.replace` relationship should **not** be bundled with it (whether or not any
subsequent replacements are themselves redacted). Note that this behaviour is subsequent replacements are themselves redacted). Note that this behaviour is
specific to the `m.replace` relationship. See also [redactions of edited specific to the `m.replace` relationship. See also [redactions of edited
events](#redactions-of-edited-events) below. events](#redactions-of-edited-events) below.
{{< changed-in v="1.7" >}} In previous versions of the specification, only the **Note:** the `content` of the original event is left intact. In particular servers
`event_id`, `origin_server_ts`, and `sender` of the replacement event were included should **not** replace the content with that of the replacement event.
in the aggregation. v1.7 extends the aggregation to the full event.
{{< changed-in v="1.7" >}} In previous versions of the specification, servers {{ boxes/rationale }}
were expected to replace the content of the original event with that of the In previous versions of the specification, servers were expected to replace the
replacement event. However that behaviour made reliable client-side content of an edited event whenever it was served to clients (with the
implementation difficult, and servers should no longer make this replacement. exception of the
[`GET /_matrix/client/v3/rooms/{roomId}/event/{eventId}`](#get_matrixclientv3roomsroomideventeventid)
endpoint). However, that behaviour made reliable client-side implementation
difficult, and servers should no longer make this replacement.
{{ /boxes/rationale }}
#### Client behaviour #### Client behaviour