Filip/matrix-spec
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-spec synced 2026-04-23 19:24:10 +02:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Mayeul Cantan <mayeul.cantan@gmail.com>
This commit is contained in:
Kitsune Ral 2020-07-25 12:44:23 +02:00 committed by GitHub
parent 7b574448db
commit c60368338c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
proposals/2312-matrix-uri.md
View file

@ -252,10 +252,7 @@ describes two possible actions:
* `action=join` is only valid in a URI resolving to a Matrix room; * `action=join` is only valid in a URI resolving to a Matrix room;
applications MUST ignore it if found in other contexts and MUST NOT generate applications MUST ignore it if found in other contexts and MUST NOT generate
it for other Matrix resources. This action means that client applications it for other Matrix resources. This action means that client applications
SHOULD attempt to join it using the standard CS API means. Client SHOULD attempt to join it using the standard CS API means.
applications SHOULD ask for user confirmation before joining if the user
is neither a joined member of the room nor of its immediate
[successor or predecessor](https://matrix.org/docs/spec/client_server/latest#module-room-upgrades).
* `action=chat` is only valid in a URI resolving to a Matrix user; * `action=chat` is only valid in a URI resolving to a Matrix user;
applications MUST ignore it if found in other contexts and MUST NOT generate applications MUST ignore it if found in other contexts and MUST NOT generate
it for other Matrix resources. A URI with this action that a client application it for other Matrix resources. A URI with this action that a client application
@ -344,8 +341,7 @@ comparisons are case-INsensitive.
[routing](https://matrix.org/docs/spec/appendices#routing). [routing](https://matrix.org/docs/spec/appendices#routing).
b. If `query` contains one or more items starting with `action=`: treat b. If `query` contains one or more items starting with `action=`: treat
_the last_ such item as an instruction for joining or opening a direct _the last_ such item as an instruction, as this proposal defines in [query](#query).
chat, as per this proposal.
The classes of URIs and corresponding default actions (along with relevant The classes of URIs and corresponding default actions (along with relevant
CS API calls) are collected as follows. This is non-normative and just provides CS API calls) are collected as follows. This is non-normative and just provides