Merge remote-tracking branch 'origin/main' into rav/anchors_for_definitions

.github/workflows/checks.yaml

@@ -0,0 +1,18 @@
+# workflow steps that ought to pass on a PR, but shouldn't block a preview.
+
+name: "Checks"
+on:
+  pull_request:
+ 
+jobs:
+  check-newsfragments:
+    name: "🔎 Check that new newsfragments are valid"
+    if: github.event_name == 'pull_request'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - run: scripts/check-newsfragments
+        env:
+          PULL_REQUEST_NUMBER: ${{ github.event.number }}

.github/workflows/main.yml

@@ -44,18 +44,6 @@ jobs:
       - name: "🔎 Run validator"
         run: |
           /env/bin/python scripts/check-event-schema-examples.py
-
-  check-newsfragments:
-    name: "🔎 Check that new newsfragments are valid"
-    if: github.event_name == 'pull_request'
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          fetch-depth: 0
-      - run: scripts/check-newsfragments
-        env:
-          PULL_REQUEST_NUMBER: ${{ github.event.number }}
         
   calculate-baseurl:
     name: "⚙️ Calculate baseURL for later jobs"

assets/scss/custom.scss

@@ -307,23 +307,24 @@ footer {
     margin: 1.5rem 0 .75rem 0;
   }
 
-  h2 + table, h3 + table, h3 + div.highlight {
-    margin-top: 0;
-  }
-
   hr {
     border-bottom: 2px solid $dark;
     margin-bottom: 1.5rem;
   }
 
   p code, table code {
-    background-color: $white;
+    background-color: inherit;
   }
 
   table {
     table-layout: fixed;
     width: 100%;
 
+    // add some space between two tables when they are right next to each other
+    & + table {
+        margin-top: 4rem;
+    }
+
     caption {
       caption-side: top;
       color: $dark;

changelogs/client_server/newsfragments/1179.clarification

@@ -0,0 +1 @@
+Tweak the styling of `<code>` snippets in tables rendered from OpenAPI definitions.

changelogs/client_server/newsfragments/1190.feature

@@ -0,0 +1 @@
+Add a `.m.rule.room.server_acl` push rule to match `m.room.server_acl` events, as per [MSC3786](https://github.com/matrix-org/matrix-spec-proposals/pull/3786).

changelogs/internal/newsfragments/1194.feature

@@ -0,0 +1 @@
+Add internal changes changelog section.

changelogs/room_versions/newsfragments/1175.clarification

@@ -0,0 +1 @@
+For room versions 7 through 10: Clarify that `invite->knock` is actually a legal transition.

changelogs/server_server/newsfragments/1179.clarification

@@ -0,0 +1 @@
+Tweak the styling of `<code>` snippets in tables rendered from OpenAPI definitions.

content/client-server-api/modules/push.md

@@ -520,6 +520,33 @@ Definition:
 }
 ```
 
+**`.m.rule.room.server_acl`**
+
+Suppresses notifications for [`m.room.server_acl`](#mroomserver_acl) events.
+
+Definition:
+
+```json
+{
+    "rule_id": ".m.rule.room.server_acl",
+    "default": true,
+    "enabled": true,
+    "conditions": [
+        {
+            "kind": "event_match",
+            "key": "type",
+            "pattern": "m.room.server_acl"
+        },
+        {
+            "kind": "event_match",
+            "key": "state_key",
+            "pattern": ""
+        }
+    ],
+    "actions": []
+}
+```
+
 **`.m.rule.roomnotif`**
 
 Matches any message whose content is unencrypted and contains the text

content/rooms/fragments/v8-auth-rules.md

@@ -118,8 +118,7 @@ The rules are as follows:
     7. If `membership` is `knock`:
         1.  If the `join_rule` is anything other than `knock`, reject.
         2.  If `sender` does not match `state_key`, reject.
-        3.  If the `sender`'s current membership is not `ban`, `invite`,
+        3.  If the `sender`'s current membership is not `ban` or `join`, allow.
-            or `join`, allow.
         4.  Otherwise, reject.
     8.  Otherwise, the membership is unknown. Reject.
 5.  If the `sender`'s current membership state is not `join`, reject.

content/rooms/v10.md

@@ -193,8 +193,7 @@ The rules are as follows:
             If the `join_rule` is anything other than `knock` or
             `knock_restricted`, reject.
         2.  If `sender` does not match `state_key`, reject.
-        3.  If the `sender`'s current membership is not `ban`, `invite`,
+        3.  If the `sender`'s current membership is not `ban` or `join`, allow.
-            or `join`, allow.
         4.  Otherwise, reject.
     8.  Otherwise, the membership is unknown. Reject.
 5.  If the `sender`'s current membership state is not `join`, reject.

content/rooms/v7.md

@@ -135,8 +135,7 @@ The rules are as follows:
     6. If `membership` is `knock`:
         1.  If the `join_rule` is anything other than `knock`, reject.
         2.  If `sender` does not match `state_key`, reject.
-        3.  If the `sender`'s current membership is not `ban`, `invite`,
+        3.  If the `sender`'s current membership is not `ban` or `join`, allow.
-            or `join`, allow.
         4.  Otherwise, reject.
     7.  Otherwise, the membership is unknown. Reject.
 5.  If the `sender`'s current membership state is not `join`, reject.

layouts/shortcodes/changelog/changelog-changes.html

@@ -38,6 +38,7 @@
 {{ partial "render-api-changes" (dict "title" "Push Gateway API" "id" "push-gateway-api" "path" (path.Join $path "push_gateway")) }}
 {{ partial "render-api-changes" (dict "title" "Room Versions" "id" "room-versions" "path" (path.Join $path "room_versions")) }}
 {{ partial "render-api-changes" (dict "title" "Appendices" "id" "appendices" "path" (path.Join $path "appendices")) }}
+{{ partial "render-api-changes" (dict "title" "Internal Changes/Tooling" "id" "internal" "path" (path.Join $path "internal")) }}
 
 {{ define "partials/render-api-changes" }}
 <h3 id="{{.id}}">{{ .title }}</h3>

scripts/generate-changelog.sh

@@ -12,6 +12,7 @@ cd changelogs
 rm -f rendered.*
 
 # Reversed order so that room versions ends up on the bottom
+towncrier --name "Internal Changes/Tooling" --dir "./internal" --config "./pyproject.toml" --yes
 towncrier --name "Appendices" --dir "./appendices" --config "./pyproject.toml" --yes
 towncrier --name "Room Versions" --dir "./room_versions" --config "./pyproject.toml" --yes
 towncrier --name "Push Gateway API" --dir "./push_gateway" --config "./pyproject.toml" --yes