Filip/matrix-spec
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-spec synced 2026-01-29 10:33:43 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse source 
Co-Authored-By: Travis Ralston <travpc@gmail.com>
Co-Authored-By: Kitsune Ral <Kitsune-Ral@users.sf.net>
This commit is contained in:
Richard van der Hoff 2019-07-30 08:00:48 +01:00 committed by GitHub
parent 9e264fedc9
commit f1f293678b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
proposals/2176-update-redaction-rules.md
View file

@ -12,7 +12,7 @@ redaction algorithm also change the way that [event
hashes](https://matrix.org/docs/spec/server_server/r0.1.2#calculating-the-reference-hash-for-an-event) hashes](https://matrix.org/docs/spec/server_server/r0.1.2#calculating-the-reference-hash-for-an-event)
(and hence event IDs) are calculated. (and hence event IDs) are calculated.
The following *event* keys should be *removed* from the list of those to be The following *event* keys are to be *removed* from the list of those to be
preserved by a redaction: preserved by a redaction:
* `membership` * `membership`
@ -21,14 +21,14 @@ preserved by a redaction:
(Note this refers to the *event-level* `membership` property, rather than the (Note this refers to the *event-level* `membership` property, rather than the
similarly-named sub-property under the `content` key.) similarly-named sub-property under the `content` key.)
Rationale: neither of the above properties have defined meanings in the Matrix Rationale: neither of the above properties have defined meanings any more in the Matrix
protocol, so there is no reason for them to be special-cased in this way. protocol, so there is no reason for them to be special-cased in this way.
The following should be added to the list of subkeys of the content property The following are to be added to the list of subkeys of the content property
which should be preserved: which are preserved:
* `m.room.create` should preserve *all* content. Rationale: the values in a * `m.room.create` preserves *all* content. Rationale: the values in a
`create` event are deliberately intented to last the lifetime of the room, `create` event are deliberately intended to last the lifetime of the room,
and if values are redacted, there is no way to add correct settings and if values are redacted, there is no way to add correct settings
afterwards. It therefore seems non-sensical to allow redaction of a `create` afterwards. It therefore seems non-sensical to allow redaction of a `create`
event. event.
@ -63,8 +63,8 @@ proposed for a redaction:
`m.room.encryption` have no effect, and servers do not use the value of the `m.room.encryption` have no effect, and servers do not use the value of the
property to authenticate events. property to authenticate events.
The effect of redacting an `m.room.redaction` event is much the same as that The effect of redacting an `m.room.encryption` event is much the same as that
of sending a new `m.room.redaction` event with no `algorithm` key. It's of sending a new `m.room.encryption` event with no `algorithm` key. It's
unlikely to be what was intended, but adding rules to the redaction unlikely to be what was intended, but adding rules to the redaction
algorithm will not help this. algorithm will not help this.