Merge 72b34b863f into 23ff7f1343

Fix minor typo in content hash calculations (#2128 )
* Fix minor typo in content hash calculations * Changelog
2026-04-14 07:04:09 +02:00 · 2025-04-08 15:13:50 +01:00 · 2025-04-07 14:28:00 -06:00 · 2025-01-28 19:03:28 +00:00 · 2025-01-28 19:02:09 +00:00
5 changed files with 13 additions and 3 deletions
--- a/changelogs/server_server/newsfragments/2067.clarification
+++ b/changelogs/server_server/newsfragments/2067.clarification
@ -0,0 +1 @@
+Add a note to the invite endpoints that invites to local users may be received twice over federation if the homeserver is already in the room.
--- a/changelogs/server_server/newsfragments/2128.clarification
+++ b/changelogs/server_server/newsfragments/2128.clarification
@ -0,0 +1 @@
+Fix various typos throughout the specification.
--- a/content/server-server-api.md
+++ b/content/server-server-api.md
@ -1337,7 +1337,7 @@ calculated as follows.
 The *content hash* of an event covers the complete event including the
 *unredacted* contents. It is calculated as follows.

-First, any existing `unsigned`, `signature`, and `hashes` members are
+First, any existing `unsigned`, `signatures`, and `hashes` properties are
 removed. The resulting object is then encoded as [Canonical
 JSON](/appendices#canonical-json), and the JSON is hashed using
 SHA-256.
--- a/data/api/server-server/invites-v1.yaml
+++ b/data/api/server-server/invites-v1.yaml
@ -20,7 +20,7 @@ paths:
    put:
      summary: Invites a remote user to a room
      description: |-
-        Invites a remote user to a room. Once the event has been  signed by both the inviting
+        Invites a remote user to a room. Once the event has been signed by both the inviting
        homeserver and the invited homeserver, it can be sent to all of the servers in the
        room by the inviting homeserver.

@ -32,6 +32,10 @@ paths:
        [room version specification](/rooms) for precise event formats. **The request and response
        bodies here describe the common event fields in more detail and may be missing other
        required fields for a PDU.**
+
+        Also note that if the remote homeserver is already in the room, it will receive the
+        invite event twice; once through this endpoint, and again through a [federation
+        transaction](https://spec.matrix.org/v1.13/server-server-api/#transactions).
      operationId: sendInviteV1
      security:
        - signedRequest: []
--- a/data/api/server-server/invites-v2.yaml
+++ b/data/api/server-server/invites-v2.yaml
@ -24,7 +24,7 @@ paths:
        This API is nearly identical to the v1 API with the exception of the request
        body being different, and the response format fixed.

-        Invites a remote user to a room. Once the event has been  signed by both the inviting
+        Invites a remote user to a room. Once the event has been signed by both the inviting
        homeserver and the invited homeserver, it can be sent to all of the servers in the
        room by the inviting homeserver.

@ -36,6 +36,10 @@ paths:
        [room version specification](/rooms) for precise event formats. **The request and response
        bodies here describe the common event fields in more detail and may be missing other
        required fields for a PDU.**
+
+        Also note that if the remote homeserver is already in the room, it will receive the
+        invite event twice; once through this endpoint, and again through a [federation
+        transaction](https://spec.matrix.org/v1.13/server-server-api/#transactions).
      operationId: sendInviteV2
      security:
        - signedRequest: []
Author	SHA1	Message	Date
Andrew Morgan	0278bf6839	Merge `72b34b863f` into `23ff7f1343`	2025-04-08 15:13:50 +01:00
Travis Ralston	23ff7f1343	Fix minor typo in content hash calculations (#2128 ) Some checks failed Spec / 🔎 Validate OpenAPI specifications (push) Has been cancelled Details Spec / 🔎 Check Event schema examples (push) Has been cancelled Details Spec / 🔎 Check OpenAPI definitions examples (push) Has been cancelled Details Spec / 🔎 Check JSON Schemas inline examples (push) Has been cancelled Details Spec / ⚙️ Calculate baseURL for later jobs (push) Has been cancelled Details Spec / 📢 Run towncrier for changelog (push) Has been cancelled Details Spell Check / Spell Check with Typos (push) Has been cancelled Details Spec / 🐍 Build OpenAPI definitions (push) Has been cancelled Details Spec / 📖 Build the spec (push) Has been cancelled Details Spec / 🔎 Validate generated HTML (push) Has been cancelled Details Spec / 📖 Build the historical backup spec (push) Has been cancelled Details * Fix minor typo in content hash calculations * Changelog	2025-04-07 14:28:00 -06:00
Andrew Morgan	72b34b863f	newsfile	2025-01-28 19:03:28 +00:00
Andrew Morgan	4d84d75bb6	Add a note to the federation invite endpoints that invites can be sent twice As this may be non-obvious when implementing behaviour that is triggered by an incoming invite event. See https://github.com/matrix-org/matrix-spec/issues/2062 for more context.	2025-01-28 19:02:09 +00:00
				`@ -0,0 +1 @@`
				`Add a note to the invite endpoints that invites to local users may be received twice over federation if the homeserver is already in the room.`
				`@ -0,0 +1 @@`
				`Fix various typos throughout the specification.`