Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
playwright/browser_patches/firefox/BUILD_NUMBER

3 lines
66 B
Plaintext
Raw Normal View History

browser(firefox): remove the hack around setting viewport size (#4010) Juggler code had a bug where we subscribed to window and tab events, but did not iterate collections of current windows and tabs. As a result, we were sometimes failing to set viewport size for the initial window, and implemented an artificial promise to workaround the problem. This patch: - starts calling `onOpenWindow` and `onOpenTabListener` callbacks for *all* windows and tabs - current and future, eliminating the race condition. This worked too well and we started overriding window sizes that were set by users with `window.open(url, 'width=300;height=400')` (we have a test for this). To fix this, we now plumb `CHROME_WITH_SIZE` flag from appWindow and override viewport iff this flag is not set. After this patch, we will use the `onTabOpened` event to move user agent emulation to the browser-side. References #3995
2020-09-30 09:36:46 +02:00
1175
Changed: lushnikov@chromium.org Wed Sep 30 00:44:40 MDT 2020
Reference in a new issue Copy permalink