From 00057df92b8b2caac71b4a99f61f698805c84496 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Sat, 11 Jan 2020 08:37:51 -0800 Subject: [PATCH] test: uncomment more webkit tests (#461) --- package.json | 2 +- test/accessibility.spec.js | 16 +++++++++++++++- test/mouse.spec.js | 4 ++-- 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 9f8b067f19..8e54a52d7c 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "playwright": { "chromium_revision": "724623", "firefox_revision": "1011", - "webkit_revision": "1082" + "webkit_revision": "1084" }, "scripts": { "unit": "node test/test.js", diff --git a/test/accessibility.spec.js b/test/accessibility.spec.js index 3c255299ac..d24224a580 100644 --- a/test/accessibility.spec.js +++ b/test/accessibility.spec.js @@ -135,7 +135,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROME, WEBKIT}) { }; expect(findFocusedNode(await page.accessibility.snapshot({interestingOnly: false}))).toEqual(golden); }); - it.skip(WEBKIT)('roledescription', async({page}) => { + it('roledescription', async({page}) => { await page.setContent('
Hi
'); const snapshot = await page.accessibility.snapshot(); expect(snapshot.children[0].roledescription).toEqual('foo'); @@ -178,6 +178,20 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROME, WEBKIT}) { role: 'pagetab', name: 'Tab2' }] + } : WEBKIT ? { + role: 'WebArea', + name: '', + roledescription: 'HTML content', + children: [{ + role: 'tab', + name: 'Tab1', + roledescription: 'tab', + selected: true + }, { + role: 'tab', + name: 'Tab2', + roledescription: 'tab', + }] } : { role: 'WebArea', name: '', diff --git a/test/mouse.spec.js b/test/mouse.spec.js index b8f5d1fa34..df64f60100 100644 --- a/test/mouse.spec.js +++ b/test/mouse.spec.js @@ -104,7 +104,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROME, WEBKIT, MA await page.hover('#button-6'); expect(await page.evaluate(() => document.querySelector('button:hover').id)).toBe('button-6'); }); - it.skip(WEBKIT)('should set modifier keys on click', async({page, server}) => { + it('should set modifier keys on click', async({page, server}) => { await page.goto(server.PREFIX + '/input/scrollable.html'); await page.evaluate(() => document.querySelector('#button-3').addEventListener('mousedown', e => window.lastEvent = e, true)); const modifiers = {'Shift': 'shiftKey', 'Control': 'ctrlKey', 'Alt': 'altKey', 'Meta': 'metaKey'}; @@ -145,7 +145,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROME, WEBKIT, MA ]); }); // @see https://crbug.com/929806 - it.skip(WEBKIT)('should work with mobile viewports and cross process navigations', async({page, server}) => { + it('should work with mobile viewports and cross process navigations', async({page, server}) => { await page.goto(server.EMPTY_PAGE); await page.setViewport({width: 360, height: 640, isMobile: true}); await page.goto(server.CROSS_PROCESS_PREFIX + '/mobile.html');