Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: update webview2 skipme's (#32984)

Browse source 
This leaves only reasonable skipmes for WebView2 in the code base.
This commit is contained in:
Max Schmitt 2024-10-07 11:08:07 +02:00 committed by GitHub
parent 317ddd4117
commit 001ba37706
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 7 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/page/locator-misc-2.spec.ts
View file

@ -42,8 +42,8 @@ it('should scroll into view', async ({ page, server, isAndroid }) => {
} }
}); });
it('should scroll zero-sized element into view', async ({ page, isAndroid, isElectron, isWebView2, browserName, isMac, macVersion }) => { it('should scroll zero-sized element into view', async ({ page, isAndroid, isElectron, browserName, isMac, macVersion }) => {
it.fixme(isAndroid || isElectron || isWebView2); it.fixme(isAndroid || isElectron);
it.skip(browserName === 'webkit' && isMac && macVersion < 11, 'WebKit for macOS 10.15 is frozen.'); it.skip(browserName === 'webkit' && isMac && macVersion < 11, 'WebKit for macOS 10.15 is frozen.');
await page.setContent(` await page.setContent(`

6
tests/page/page-accessibility.spec.ts
View file

@ -143,9 +143,8 @@ it('should not report text nodes inside controls', async function({ page, browse
expect(await page.accessibility.snapshot()).toEqual(golden); expect(await page.accessibility.snapshot()).toEqual(golden);
}); });
it('rich text editable fields should have children', async function({ page, browserName, browserVersion, isWebView2 }) { it('rich text editable fields should have children', async function({ page, browserName, browserVersion }) {
it.skip(browserName === 'webkit', 'WebKit rich text accessibility is iffy'); it.skip(browserName === 'webkit', 'WebKit rich text accessibility is iffy');
it.skip(isWebView2, 'WebView2 is missing a Chromium fix');
await page.setContent(` await page.setContent(`
<div contenteditable="true"> <div contenteditable="true">
@ -177,9 +176,8 @@ it('rich text editable fields should have children', async function({ page, brow
expect(snapshot.children[0]).toEqual(golden); expect(snapshot.children[0]).toEqual(golden);
}); });
it('rich text editable fields with role should have children', async function({ page, browserName, browserVersion, isWebView2 }) { it('rich text editable fields with role should have children', async function({ page, browserName, browserVersion }) {
it.skip(browserName === 'webkit', 'WebKit rich text accessibility is iffy'); it.skip(browserName === 'webkit', 'WebKit rich text accessibility is iffy');
it.skip(isWebView2, 'WebView2 is missing a Chromium fix');
await page.setContent(` await page.setContent(`
<div contenteditable="true" role='textbox'> <div contenteditable="true" role='textbox'>

3
tests/page/page-click-scroll.spec.ts
View file

@ -78,9 +78,8 @@ it('should scroll into view display:contents with position', async ({ page, brow
expect(await page.evaluate('window._clicked')).toBe(true); expect(await page.evaluate('window._clicked')).toBe(true);
}); });
it('should not crash when force-clicking hidden input', async ({ page, isWebView2 }) => { it('should not crash when force-clicking hidden input', async ({ page }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/18183' }); it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/18183' });
it.fixme(isWebView2);
await page.setContent(`<input type=hidden>`); await page.setContent(`<input type=hidden>`);
const error = await page.locator('input').click({ force: true, timeout: 2000 }).catch(e => e); const error = await page.locator('input').click({ force: true, timeout: 2000 }).catch(e => e);

3
tests/page/page-screenshot.spec.ts
View file

@ -291,10 +291,9 @@ it.describe('page screenshot', () => {
expect(screenshot).toMatchSnapshot('screenshot-canvas.png'); expect(screenshot).toMatchSnapshot('screenshot-canvas.png');
}); });
it('should capture canvas changes', async ({ page, isElectron, browserName, isMac, isWebView2 }) => { it('should capture canvas changes', async ({ page, isElectron, browserName, isMac }) => {
it.fixme(browserName === 'webkit' && isMac, 'https://github.com/microsoft/playwright/issues/8796,https://github.com/microsoft/playwright/issues/16180'); it.fixme(browserName === 'webkit' && isMac, 'https://github.com/microsoft/playwright/issues/8796,https://github.com/microsoft/playwright/issues/16180');
it.skip(isElectron); it.skip(isElectron);
it.skip(isWebView2);
await page.goto('data:text/html,<canvas></canvas>'); await page.goto('data:text/html,<canvas></canvas>');
await page.evaluate(() => { await page.evaluate(() => {
const canvas = document.querySelector('canvas'); const canvas = document.querySelector('canvas');

2
tests/webview2/webview2-app/webview2.csproj
View file

@ -9,7 +9,7 @@
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<PackageReference Include="Microsoft.Web.WebView2" Version="1.0.2210.55" /> <PackageReference Include="Microsoft.Web.WebView2" Version="1.0.2792.45" />
</ItemGroup> </ItemGroup>
</Project> </Project>