review feedback

This commit is contained in:
Max Schmitt 2024-09-24 12:23:23 +02:00
parent 2e603ddf77
commit 00257651fd
3 changed files with 3 additions and 3 deletions

View file

@ -19,7 +19,7 @@ import type { ConsoleMessage } from 'playwright';
test.describe('cli codegen', () => {
test.skip(({ mode }) => mode !== 'default');
test.skip(({ trace }) => trace === 'on' && test.info().project.name.endsWith('-codegen-mode-trace'));
test.skip(({ trace, codegenMode }) => trace === 'on' && codegenMode === 'trace-events');
test('should click', async ({ openRecorder }) => {
const { page, recorder } = await openRecorder();

View file

@ -20,7 +20,7 @@ import fs from 'fs';
test.describe('cli codegen', () => {
test.skip(({ mode }) => mode !== 'default');
test.skip(({ trace }) => trace === 'on' && test.info().project.name.endsWith('-codegen-mode-trace'));
test.skip(({ trace, codegenMode }) => trace === 'on' && codegenMode === 'trace-events');
test('should contain open page', async ({ openRecorder }) => {
const { recorder } = await openRecorder();

View file

@ -18,7 +18,7 @@ import { test, expect } from './inspectorTest';
test.describe('cli codegen', () => {
test.skip(({ mode }) => mode !== 'default');
test.skip(({ trace }) => trace === 'on' && test.info().project.name.endsWith('-codegen-mode-trace'));
test.skip(({ trace, codegenMode }) => trace === 'on' && codegenMode === 'trace-events');
test('should click locator.first', async ({ openRecorder }) => {
const { page, recorder } = await openRecorder();