From 00b41eb8d3554d71694018aa25a4aa29156b1bf3 Mon Sep 17 00:00:00 2001 From: Pengoose Date: Mon, 16 Dec 2024 23:02:57 +0900 Subject: [PATCH] chore: remove redundant check in getElementAccessibleErrorMessage --- .../src/server/injected/roleUtils.ts | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/packages/playwright-core/src/server/injected/roleUtils.ts b/packages/playwright-core/src/server/injected/roleUtils.ts index da8e2ca3a7..3349665f22 100644 --- a/packages/playwright-core/src/server/injected/roleUtils.ts +++ b/packages/playwright-core/src/server/injected/roleUtils.ts @@ -475,18 +475,14 @@ export function getElementAccessibleErrorMessage(element: Element): string { const isAriaInvalid = ariaInvalid !== null && ariaInvalid.toLowerCase() !== 'false'; if (isAriaInvalid) { const errorMessageId = element.getAttribute('aria-errormessage'); - if (errorMessageId) { - const errorMessages = getIdRefs(element, errorMessageId); - if (errorMessages.length) { - const parts = errorMessages.map(errorMessage => asFlatString( - getTextAlternativeInternal(errorMessage, { - visitedElements: new Set(), - embeddedInDescribedBy: { element: errorMessage, hidden: isElementHiddenForAria(errorMessage) }, - }) - )); - accessibleErrorMessage = parts.join(' ').trim(); - } - } + const errorMessages = getIdRefs(element, errorMessageId); + const parts = errorMessages.map(errorMessage => asFlatString( + getTextAlternativeInternal(errorMessage, { + visitedElements: new Set(), + embeddedInDescribedBy: { element: errorMessage, hidden: isElementHiddenForAria(errorMessage) }, + }) + )); + accessibleErrorMessage = parts.join(' ').trim(); } cache?.set(element, accessibleErrorMessage); }