Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: remove PWTEST_RECORDER_PORT as it was ignored (#32717)

Browse source
This commit is contained in:
Pavel Feldman 2024-09-19 13:35:52 -07:00 committed by GitHub
parent a00e1c9c4b
commit 01b44ba077
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/playwright-core/src/server/recorder/recorderApp.ts
View file

@ -123,9 +123,8 @@ export class RecorderApp extends EventEmitter implements IRecorderApp {
persistentContextOptions: { persistentContextOptions: {
noDefaultViewport: true, noDefaultViewport: true,
headless: !!process.env.PWTEST_CLI_HEADLESS || (isUnderTest() && !headed), headless: !!process.env.PWTEST_CLI_HEADLESS || (isUnderTest() && !headed),
useWebSocket: !!process.env.PWTEST_RECORDER_PORT, useWebSocket: isUnderTest(),
handleSIGINT: false, handleSIGINT: false,
args: process.env.PWTEST_RECORDER_PORT ? [`--remote-debugging-port=${process.env.PWTEST_RECORDER_PORT}`] : [],
executablePath: inspectedContext._browser.options.isChromium ? inspectedContext._browser.options.customExecutablePath : undefined, executablePath: inspectedContext._browser.options.isChromium ? inspectedContext._browser.options.customExecutablePath : undefined,
} }
}); });

1
packages/playwright-core/src/server/trace/viewer/traceViewer.ts
View file

@ -178,7 +178,6 @@ export async function openTraceViewerApp(url: string, browserName: string, optio
...options?.persistentContextOptions, ...options?.persistentContextOptions,
useWebSocket: isUnderTest(), useWebSocket: isUnderTest(),
headless: !!options?.headless, headless: !!options?.headless,
args: process.env.PWTEST_RECORDER_PORT ? [`--remote-debugging-port=${process.env.PWTEST_RECORDER_PORT}`] : [],
}, },
}); });

2
tests/library/inspector/inspectorTest.ts
View file

@ -50,7 +50,6 @@ const playwrightToAutomateInspector = require('../../../packages/playwright-core
export const test = contextTest.extend<CLITestArgs>({ export const test = contextTest.extend<CLITestArgs>({
recorderPageGetter: async ({ context, toImpl, mode }, run, testInfo) => { recorderPageGetter: async ({ context, toImpl, mode }, run, testInfo) => {
process.env.PWTEST_RECORDER_PORT = String(10907 + testInfo.workerIndex);
testInfo.skip(mode.startsWith('service')); testInfo.skip(mode.startsWith('service'));
await run(async () => { await run(async () => {
while (!toImpl(context).recorderAppForTest) while (!toImpl(context).recorderAppForTest)
@ -69,7 +68,6 @@ export const test = contextTest.extend<CLITestArgs>({
}, },
runCLI: async ({ childProcess, browserName, channel, headless, mode, launchOptions }, run, testInfo) => { runCLI: async ({ childProcess, browserName, channel, headless, mode, launchOptions }, run, testInfo) => {
process.env.PWTEST_RECORDER_PORT = String(10907 + testInfo.workerIndex);
testInfo.skip(mode.startsWith('service')); testInfo.skip(mode.startsWith('service'));
await run((cliArgs, { autoExitWhen } = {}) => { await run((cliArgs, { autoExitWhen } = {}) => {