Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(codegen): use new toHaveURL syntax (#8624)

Browse source
This commit is contained in:
Henrik Nygren 2021-09-02 18:24:31 +03:00 committed by GitHub
parent 63e9287b36
commit 0202cdf797
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/server/supplements/recorder/javascript.ts
View file

@ -95,7 +95,7 @@ export class JavaScriptLanguageGenerator implements LanguageGenerator {
formatter.add(`]);`); formatter.add(`]);`);
} else if (signals.assertNavigation) { } else if (signals.assertNavigation) {
if (this._isTest) if (this._isTest)
formatter.add(` expect(${pageAlias}.url()).toBe(${quote(signals.assertNavigation.url)});`); formatter.add(` await expect(${pageAlias}).toHaveURL(${quote(signals.assertNavigation.url)});`);
else else
formatter.add(` // assert.equal(${pageAlias}.url(), ${quote(signals.assertNavigation.url)});`); formatter.add(` // assert.equal(${pageAlias}.url(), ${quote(signals.assertNavigation.url)});`);
} }

2
tests/inspector/cli-codegen-1.spec.ts
View file

@ -539,7 +539,7 @@ test.describe('cli codegen', () => {
expect(sources.get('Playwright Test').text).toContain(` expect(sources.get('Playwright Test').text).toContain(`
// Click text=link // Click text=link
await page.click('text=link'); await page.click('text=link');
expect(page.url()).toBe('about:blank#foo');`); await expect(page).toHaveURL('about:blank#foo');`);
expect(sources.get('Java').text).toContain(` expect(sources.get('Java').text).toContain(`
// Click text=link // Click text=link