Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(testrunner): "sourcemapify" crash error stacktraces (#441)

Browse source 
Whenever test runner crashes due to UnhandledPromiseRejection, the
related error should be run through "sourcemap decoding".
This commit is contained in:
Andrey Lushnikov 2020-01-09 16:37:19 +00:00 committed by GitHub
parent d83d3c3851
commit 02c504ca59
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
utils/testrunner/TestRunner.js
View file

@ -260,7 +260,7 @@ class TestPass {
test.result = TestResult.Crashed; test.result = TestResult.Crashed;
this._runner._didFinishTest(test, workerId); this._runner._didFinishTest(test, workerId);
if (this._breakOnFailure && test.result !== TestResult.Ok) if (this._breakOnFailure && test.result !== TestResult.Ok)
this._terminate(TestResult.Terminated, `Terminating because a test has failed and |testRunner.breakOnFailure| is enabled`, null); await this._terminate(TestResult.Terminated, `Terminating because a test has failed and |testRunner.breakOnFailure| is enabled`, null);
} }
async _runHook(workerId, suite, hookName, ...args) { async _runHook(workerId, suite, hookName, ...args) {
@ -273,19 +273,21 @@ class TestPass {
if (error === TimeoutError) { if (error === TimeoutError) {
const location = `${hook.location.fileName}:${hook.location.lineNumber}:${hook.location.columnNumber}`; const location = `${hook.location.fileName}:${hook.location.lineNumber}:${hook.location.columnNumber}`;
const message = `${location} - Timeout Exceeded ${hook.timeout}ms while running "${hookName}" in suite "${suite.fullName}"`; const message = `${location} - Timeout Exceeded ${hook.timeout}ms while running "${hookName}" in suite "${suite.fullName}"`;
return this._terminate(TestResult.Crashed, message, null); return await this._terminate(TestResult.Crashed, message, null);
} }
if (error) { if (error) {
const location = `${hook.location.fileName}:${hook.location.lineNumber}:${hook.location.columnNumber}`; const location = `${hook.location.fileName}:${hook.location.lineNumber}:${hook.location.columnNumber}`;
const message = `${location} - FAILED while running "${hookName}" in suite "${suite.fullName}"`; const message = `${location} - FAILED while running "${hookName}" in suite "${suite.fullName}"`;
return this._terminate(TestResult.Crashed, message, error); return await this._terminate(TestResult.Crashed, message, error);
} }
return false; return false;
} }
_terminate(result, message, error) { async _terminate(result, message, error) {
if (this._termination) if (this._termination)
return false; return false;
if (error && error.stack)
await this._runner._sourceMapSupport.rewriteStackTraceWithSourceMaps(error);
this._termination = {result, message, error}; this._termination = {result, message, error};
for (const userCallback of this._runningUserCallbacks.valuesArray()) for (const userCallback of this._runningUserCallbacks.valuesArray())
userCallback.terminate(); userCallback.terminate();
@ -408,10 +410,10 @@ class TestRunner extends EventEmitter {
return result; return result;
} }
terminate() { async terminate() {
if (!this._runningPass) if (!this._runningPass)
return; return;
this._runningPass._terminate(TestResult.Terminated, 'Terminated with |TestRunner.terminate()| call', null); await this._runningPass._terminate(TestResult.Terminated, 'Terminated with |TestRunner.terminate()| call', null);
} }
timeout() { timeout() {