From 032f27ff844c3617be2fa9bfb193e8359d8dc9d7 Mon Sep 17 00:00:00 2001
From: Max Schmitt <max@schmitt.mx>
Date: Mon, 25 Mar 2024 19:17:05 +0100
Subject: [PATCH] docs: change if: always() to if: !cancelled() (#30102)

Fixes https://github.com/microsoft/playwright/issues/29451

See
https://github.com/microsoft/playwright/issues/29451#issuecomment-2008476721
for investigation.
---
 docs/src/ci-intro.md         | 4 ++--
 docs/src/test-sharding-js.md | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/src/ci-intro.md b/docs/src/ci-intro.md
index f5393cfc9e..561748b6b3 100644
--- a/docs/src/ci-intro.md
+++ b/docs/src/ci-intro.md
@@ -65,7 +65,7 @@ jobs:
     - name: Run Playwright tests
       run: npx playwright test
     - uses: actions/upload-artifact@v4
-      if: always()
+      if: ${{ !cancelled() }}
       with:
         name: playwright-report
         path: playwright-report/
@@ -103,7 +103,7 @@ jobs:
     - name: Run your tests
       run: pytest --tracing=retain-on-failure
     - uses: actions/upload-artifact@v4
-      if: always()
+      if: ${{ !cancelled() }}
       with:
         name: playwright-traces
         path: test-results/
diff --git a/docs/src/test-sharding-js.md b/docs/src/test-sharding-js.md
index 6738dbeada..8067198b49 100644
--- a/docs/src/test-sharding-js.md
+++ b/docs/src/test-sharding-js.md
@@ -89,7 +89,7 @@ jobs:
       run: npx playwright test --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
 
     - name: Upload blob report to GitHub Actions Artifacts
-      if: always()
+      if: ${{ !cancelled() }}
       uses: actions/upload-artifact@v4
       with:
         name: blob-report-${{ matrix.shardIndex }}
@@ -104,7 +104,7 @@ jobs:
 ...
   merge-reports:
     # Merge reports after playwright-tests, even if some shards have failed
-    if: always()
+    if: ${{ !cancelled() }}
     needs: [playwright-tests]
 
     runs-on: ubuntu-latest