Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(webkit): allow fufilling requests to redirects (#1830)

Browse source
This commit is contained in:
Joel Einbinder 2020-04-16 12:36:00 -07:00 committed by GitHub
parent 5ec2c58a75
commit 036f9e50fa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/webkit/wkInterceptableRequest.ts
View file

@ -69,7 +69,7 @@ export class WKInterceptableRequest implements network.RouteDelegate {
await this._interceptedPromise;
const base64Encoded = !!response.body && !helper.isString(response.body);
const responseBody = response.body ? (base64Encoded ? response.body.toString('base64') : response.body as string) : undefined;
const responseBody = response.body ? (base64Encoded ? response.body.toString('base64') : response.body as string) : '';
const responseHeaders: { [s: string]: string; } = {};
if (response.headers) {

3
test/interception.spec.js
View file

@ -368,8 +368,7 @@ describe('Page.route', function() {
expect(response.ok()).toBe(true);
expect(intercepted).toBe(true);
});
// WebKit crashes. Firefox succeeds, but then fails to close.
it.fail(FFOX || WEBKIT)('should create a redirect', async({page, server}) => {
it('should create a redirect', async({page, server}) => {
await page.goto(server.PREFIX + '/empty.html');
await page.route('**/*', async(route, request) => {
if (request.url() !== server.PREFIX + '/redirect_this')