Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: fix ui mode tests on windows (#23553)

Browse source
This commit is contained in:
Pavel Feldman 2023-06-06 14:24:42 -07:00 committed by GitHub
parent 85be65b07b
commit 037da65d83
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/trace-viewer/src/ui/uiModeView.tsx
View file

@ -95,6 +95,7 @@ export const UIModeView: React.FC<{}> = ({
React.useEffect(() => { React.useEffect(() => {
inputRef.current?.focus(); inputRef.current?.focus();
setIsLoading(true);
initWebSocket(() => setIsDisconnected(true)).then(() => reloadTests()); initWebSocket(() => setIsDisconnected(true)).then(() => reloadTests());
}, [reloadTests]); }, [reloadTests]);
@ -403,7 +404,7 @@ const TestList: React.FC<{
// Update watch all. // Update watch all.
React.useEffect(() => { React.useEffect(() => {
if (!testModel.rootSuite) if (isLoading)
return; return;
if (watchAll) { if (watchAll) {
sendMessageNoReply('watch', { fileNames: [...fileNames] }); sendMessageNoReply('watch', { fileNames: [...fileNames] });
@ -417,7 +418,7 @@ const TestList: React.FC<{
} }
sendMessageNoReply('watch', { fileNames: [...fileNames] }); sendMessageNoReply('watch', { fileNames: [...fileNames] });
} }
}, [testModel, rootItem, fileNames, watchAll, watchedTreeIds, treeItemMap]); }, [isLoading, rootItem, fileNames, watchAll, watchedTreeIds, treeItemMap]);
const runTreeItem = (treeItem: TreeItem) => { const runTreeItem = (treeItem: TreeItem) => {
setSelectedTreeItemId(treeItem.id); setSelectedTreeItemId(treeItem.id);