Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(screenshot): avoid unnecessary work (#16035)

Browse source 
Do not evaluate when not hiding caret nor disabling animations.
This commit is contained in:
Dmitry Gozman 2022-07-29 09:23:02 -07:00 committed by GitHub
parent e07eb664a5
commit 03b0f911d9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/playwright-core/src/server/screenshotter.ts
View file

@ -140,6 +140,9 @@ export class Screenshotter {
} }
async _preparePageForScreenshot(progress: Progress, hideCaret: boolean, disableAnimations: boolean) { async _preparePageForScreenshot(progress: Progress, hideCaret: boolean, disableAnimations: boolean) {
if (!hideCaret && !disableAnimations)
return;
if (disableAnimations) if (disableAnimations)
progress.log(' disabled all CSS animations'); progress.log(' disabled all CSS animations');
await Promise.all(this._page.frames().map(async frame => { await Promise.all(this._page.frames().map(async frame => {