Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(#17879): test: rebaseline requestStorageAccess test for firefox-beta (#17884)

Browse source
This commit is contained in:
Dmitry Gozman 2022-10-06 11:02:47 -07:00 committed by GitHub
parent 3bf42ce163
commit 03c7f9c2f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tests/library/browsercontext-cookies.spec.ts
View file

@ -350,9 +350,11 @@ it('should be able to send third party cookies via an iframe', async ({ browser,
} }
}); });
it('should support requestStorageAccess', async ({ page, server, browserName, isMac, isLinux, isWindows }) => { it('should support requestStorageAccess', async ({ page, server, channel, browserName, isMac, isLinux, isWindows }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/17285' }); it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/17285' });
it.skip(browserName === 'chromium', 'requestStorageAccess API is not available in Chromium'); it.skip(browserName === 'chromium', 'requestStorageAccess API is not available in Chromium');
it.fixme(channel === 'firefox-beta', 'hasStorageAccess returns true, but no cookie is sent');
server.setRoute('/set-cookie.html', (req, res) => { server.setRoute('/set-cookie.html', (req, res) => {
res.setHeader('Set-Cookie', 'name=value; Path=/'); res.setHeader('Set-Cookie', 'name=value; Path=/');
res.end(); res.end();
@ -372,7 +374,6 @@ it('should support requestStorageAccess', async ({ page, server, browserName, is
]); ]);
expect(serverRequest.headers.cookie).toBe('name=value'); expect(serverRequest.headers.cookie).toBe('name=value');
} }
return;
} else { } else {
if (isLinux && browserName === 'webkit') if (isLinux && browserName === 'webkit')
expect(await frame.evaluate(() => document.hasStorageAccess())).toBeTruthy(); expect(await frame.evaluate(() => document.hasStorageAccess())).toBeTruthy();