From 03ca2978903221affe04996d6da205f297408219 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Sat, 2 May 2020 10:57:33 -0700 Subject: [PATCH] fix(webkit): make click work with cross-process _blank target (#2083) --- src/webkit/wkPage.ts | 4 ++-- test/navigation.spec.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/webkit/wkPage.ts b/src/webkit/wkPage.ts index 9471ddbbdc..d88f39bf84 100644 --- a/src/webkit/wkPage.ts +++ b/src/webkit/wkPage.ts @@ -257,8 +257,8 @@ export class WKPage implements PageDelegate { }); assert(targetInfo.type === 'page', 'Only page targets are expected in WebKit, received: ' + targetInfo.type); - if (!this._initializedPage) { - assert(!targetInfo.isProvisional); + if (!targetInfo.isProvisional) { + assert(!this._initializedPage); let pageOrError: Page | Error; try { this._setSession(session); diff --git a/test/navigation.spec.js b/test/navigation.spec.js index 7fed6ead50..d69a94c1ca 100644 --- a/test/navigation.spec.js +++ b/test/navigation.spec.js @@ -994,7 +994,7 @@ describe('Click navigation', function() { await page.goto(server.EMPTY_PAGE); await page.click('"Click me"'); }); - it.fail(WEBKIT)('should work with cross-process _blank target', async({page, server}) => { + it('should work with cross-process _blank target', async({page, server}) => { server.setRoute('/empty.html', (req, res) => { res.end(`Click me`); });