From 044f77445883137a3862aef693777e617658a057 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Tue, 10 Mar 2020 13:14:12 -0700 Subject: [PATCH] test: unflake should fail when frame detaches --- test/navigation.spec.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/test/navigation.spec.js b/test/navigation.spec.js index 188300f3cf..4f97c5b153 100644 --- a/test/navigation.spec.js +++ b/test/navigation.spec.js @@ -1113,18 +1113,15 @@ module.exports.describe = function({testRunner, expect, playwright, MAC, WIN, FF expect(response.frame()).toBe(frame); expect(page.url()).toContain('/frames/one-frame.html'); }); - it.fail(true)('should fail when frame detaches', async({page, server}) => { + it('should fail when frame detaches', async({page, server}) => { await page.goto(server.PREFIX + '/frames/one-frame.html'); const frame = page.frames()[1]; - server.setRoute('/empty.html', () => {}); let error = null; await Promise.all([ frame.waitForNavigation().catch(e => error = e), - server.waitForRequest('/empty.html').then(() => { - page.$eval('iframe', frame => frame.remove()); - }), - frame.evaluate(() => window.location = '/empty.html'), + frame.evaluate('window.location = "/empty.html"'), + page.evaluate('setTimeout(() => document.querySelector("iframe").remove())'), ]).catch(e => error = e); expect(error.message).toContain('frame was detached'); });