Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

tests(firefox): unskip network idle tests (#1832)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-04-16 14:25:19 -07:00 committed by GitHub
parent e67603db27
commit 04ed68384b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
test/navigation.spec.js
View file

@ -557,9 +557,7 @@ describe('Page.goto', function() {
return page.setContent(`<script src='networkidle.js'></script>`, { waitUntil: 'networkidle2' }); return page.setContent(`<script src='networkidle.js'></script>`, { waitUntil: 'networkidle2' });
}, true); }, true);
}); });
it.fail(FFOX)('should wait for networkidle0 in setContent with request from previous navigation', async({page, server}) => { it('should wait for networkidle0 in setContent with request from previous navigation', async({page, server}) => {
// TODO: in Firefox window.stop() does not cancel outstanding requests, and we also lack 'init' lifecycle,
// therefore we don't clear inflight requests at the right time.
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
server.setRoute('/foo.js', () => {}); server.setRoute('/foo.js', () => {});
await page.setContent(`<script>fetch('foo.js');</script>`); await page.setContent(`<script>fetch('foo.js');</script>`);
@ -567,9 +565,7 @@ describe('Page.goto', function() {
return page.setContent(`<script src='networkidle.js'></script>`, { waitUntil: 'networkidle0' }); return page.setContent(`<script src='networkidle.js'></script>`, { waitUntil: 'networkidle0' });
}, true); }, true);
}); });
it.fail(FFOX)('should wait for networkidle2 in setContent with request from previous navigation', async({page, server}) => { it('should wait for networkidle2 in setContent with request from previous navigation', async({page, server}) => {
// TODO: in Firefox window.stop() does not cancel outstanding requests, and we also lack 'init' lifecycle,
// therefore we don't clear inflight requests at the right time.
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
server.setRoute('/foo.js', () => {}); server.setRoute('/foo.js', () => {});
await page.setContent(`<script>fetch('foo.js');</script>`); await page.setContent(`<script>fetch('foo.js');</script>`);