Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feedback

Browse source
This commit is contained in:
Max Schmitt 2024-09-07 09:07:53 +02:00
parent 026d618fa1
commit 0508347a5f
3 changed files with 8 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
.github/workflows/tests_bidi.yml vendored
View file

@ -8,6 +8,7 @@ on:
paths: paths:
- .github/workflows/tests_bidi.yml - .github/workflows/tests_bidi.yml
schedule: schedule:
# Run every day at midnight
- cron: '0 0 * * *' - cron: '0 0 * * *'
env: env:
@ -26,15 +27,9 @@ jobs:
fail-fast: false fail-fast: false
matrix: matrix:
# TODO: add Firefox # TODO: add Firefox
channel: [bidi-chrome-beta] channel: [bidi-chrome-stable]
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- name: Install browser
run: |
if [[ ${{ matrix.channel }} == bidi-chrome-beta ]]; then
curl -O https://dl.google.com/linux/direct/google-chrome-beta_current_amd64.deb
sudo dpkg -i google-chrome-beta_current_amd64.deb
fi
- uses: actions/setup-node@v4 - uses: actions/setup-node@v4
with: with:
node-version: 20 node-version: 20

10
packages/playwright-core/src/server/registry/index.ts
View file

@ -354,7 +354,7 @@ function readDescriptors(browsersJSON: BrowsersJSON) {
export type BrowserName = 'chromium' | 'firefox' | 'webkit' | 'bidi'; export type BrowserName = 'chromium' | 'firefox' | 'webkit' | 'bidi';
type InternalTool = 'ffmpeg' | 'firefox-beta' | 'chromium-tip-of-tree' | 'android'; type InternalTool = 'ffmpeg' | 'firefox-beta' | 'chromium-tip-of-tree' | 'android';
type BidiChannel = 'bidi-firefox-stable' | 'bidi-chrome-canary' | 'bidi-chrome-beta'; type BidiChannel = 'bidi-firefox-stable' | 'bidi-chrome-canary' | 'bidi-chrome-stable';
type ChromiumChannel = 'chrome' | 'chrome-beta' | 'chrome-dev' | 'chrome-canary' | 'msedge' | 'msedge-beta' | 'msedge-dev' | 'msedge-canary'; type ChromiumChannel = 'chrome' | 'chrome-beta' | 'chrome-dev' | 'chrome-canary' | 'msedge' | 'msedge-beta' | 'msedge-dev' | 'msedge-canary';
const allDownloadable = ['chromium', 'firefox', 'webkit', 'ffmpeg', 'firefox-beta', 'chromium-tip-of-tree']; const allDownloadable = ['chromium', 'firefox', 'webkit', 'ffmpeg', 'firefox-beta', 'chromium-tip-of-tree'];
@ -530,10 +530,10 @@ export class Registry {
'darwin': '/Applications/Firefox.app/Contents/MacOS/firefox', 'darwin': '/Applications/Firefox.app/Contents/MacOS/firefox',
'win32': '\\Mozilla Firefox\\firefox.exe', 'win32': '\\Mozilla Firefox\\firefox.exe',
})); }));
this._executables.push(this._createBidiChannel('bidi-chrome-beta', { this._executables.push(this._createBidiChannel('bidi-chrome-stable', {
'linux': '/opt/google/chrome-beta/chrome', 'linux': '/opt/google/chrome/chrome',
'darwin': '/Applications/Google Chrome Beta.app/Contents/MacOS/Google Chrome Beta', 'darwin': '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
'win32': `\\Google\\Chrome Beta\\Application\\chrome.exe`, 'win32': `\\Google\\Chrome\\Application\\chrome.exe`,
})); }));
this._executables.push(this._createBidiChannel('bidi-chrome-canary', { this._executables.push(this._createBidiChannel('bidi-chrome-canary', {
'linux': '', 'linux': '',

2
tests/bidi/playwright.config.ts
View file

@ -63,7 +63,7 @@ if (executablePath && !process.env.TEST_WORKER_INDEX)
console.error(`Using executable at ${executablePath}`); console.error(`Using executable at ${executablePath}`);
const testIgnore: RegExp[] = []; const testIgnore: RegExp[] = [];
const browserToChannels = { const browserToChannels = {
'_bidiChromium': ['bidi-chrome-beta'], '_bidiChromium': ['bidi-chrome-stable'],
'_bidiFirefox': ['bidi-firefox-stable'], '_bidiFirefox': ['bidi-firefox-stable'],
}; };
for (const [key, channels] of Object.entries(browserToChannels)) { for (const [key, channels] of Object.entries(browserToChannels)) {