From 0514ecc1af6ff962509ea2fee5a10275f78aa514 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Wed, 22 Dec 2021 11:17:43 -0800 Subject: [PATCH] test: mark trace-viewer tests as slow, unflake resource order (#11070) --- tests/trace-viewer/trace-viewer.spec.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/trace-viewer/trace-viewer.spec.ts b/tests/trace-viewer/trace-viewer.spec.ts index 92eee191b8..d203c4e166 100644 --- a/tests/trace-viewer/trace-viewer.spec.ts +++ b/tests/trace-viewer/trace-viewer.spec.ts @@ -120,6 +120,7 @@ const test = playwrightTest.extend<{ showTraceViewer: (trace: string) => Promise }); test.skip(({ trace }) => trace === 'on'); +test.slow(); let traceFile: string; @@ -149,9 +150,14 @@ test.beforeAll(async function recordTrace({ browser, browserName, browserType, s } await doClick(); + // Make sure resources arrive in a predictable order. + const htmlDone = page.waitForEvent('requestfinished', request => request.url().includes('frame.html')); const styleDone = page.waitForEvent('requestfinished', request => request.url().includes('style.css')); + await page.route(server.PREFIX + '/frames/style.css', async route => { + await htmlDone; + await route.continue(); + }); await page.route(server.PREFIX + '/frames/script.js', async route => { - // Make sure script arrives after style for predictable results. await styleDone; await route.continue(); }); @@ -188,11 +194,13 @@ test('should open simple trace viewer', async ({ showTraceViewer }) => { /page.evaluate/, /page.click"Click"/, /page.waitForEvent/, + /page.waitForEvent/, /page.route/, /page.waitForNavigation/, /page.waitForTimeout/, /page.gotohttp:\/\/localhost:\d+\/frames\/frame.html/, /route.continue/, + /route.continue/, /page.setViewportSize/, ]); });