From 05f11f7da35b1379fb22359a7eb17ee8d4202f40 Mon Sep 17 00:00:00 2001
From: Max Schmitt <max@schmitt.mx>
Date: Mon, 12 Aug 2024 14:59:28 +0200
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Simon Knott <info@simonknott.de>
Signed-off-by: Max Schmitt <max@schmitt.mx>
---
 .../playwright-core/src/server/recorder/recorderApp.ts   | 2 +-
 packages/web/src/uiUtils.ts                              | 9 +++------
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/packages/playwright-core/src/server/recorder/recorderApp.ts b/packages/playwright-core/src/server/recorder/recorderApp.ts
index 354a7b382a..7f9166ae73 100644
--- a/packages/playwright-core/src/server/recorder/recorderApp.ts
+++ b/packages/playwright-core/src/server/recorder/recorderApp.ts
@@ -38,7 +38,7 @@ declare global {
     playwrightSetSelector: (selector: string, focus?: boolean) => void;
     playwrightUpdateLogs: (callLogs: CallLog[]) => void;
     dispatch(data: EventData): Promise<void>;
-    saveSettings(): Promise<void>;
+    saveSettings?(): Promise<void>;
   }
 }
 
diff --git a/packages/web/src/uiUtils.ts b/packages/web/src/uiUtils.ts
index 734a5fc0c2..794ace1dc5 100644
--- a/packages/web/src/uiUtils.ts
+++ b/packages/web/src/uiUtils.ts
@@ -167,7 +167,7 @@ export function useSetting<S>(name: string | undefined, defaultValue: S, title?:
 
 declare global {
   interface Window {
-    saveSettings(): Promise<void>;
+    saveSettings?(): Promise<void>;
   }
 }
 
@@ -181,8 +181,7 @@ export class Settings {
   setString(name: string, value: string) {
     localStorage[name] = value;
     this.onChangeEmitter.dispatchEvent(new Event(name));
-    if (window.saveSettings)
-      window.saveSettings();
+    window.saveSettings?.();
   }
 
   getObject<T>(name: string, defaultValue: T): T {
@@ -198,9 +197,7 @@ export class Settings {
   setObject<T>(name: string, value: T) {
     localStorage[name] = JSON.stringify(value);
     this.onChangeEmitter.dispatchEvent(new Event(name));
-
-    if (window.saveSettings)
-      window.saveSettings();
+    window.saveSettings?.();
   }
 }