Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore(dotnet): generate [Obsolete] on deprecated members (#8434)

Browse source
This commit is contained in:
Anže Vodovnik 2021-08-25 14:24:18 +02:00 committed by GitHub
parent db36f40422
commit 061b5c67f2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
utils/doclint/generateDotnetApi.js
View file

@ -318,6 +318,8 @@ function renderMember(member, parent, options, out) {
out.push(...XmlDoc.renderXmlDoc(member.spec, maxDocumentationColumnWidth)); out.push(...XmlDoc.renderXmlDoc(member.spec, maxDocumentationColumnWidth));
if (!member.clazz) if (!member.clazz)
out.push(`${member.required ? '[Required]\n' : ''}[JsonPropertyName("${jsonName}")]`) out.push(`${member.required ? '[Required]\n' : ''}[JsonPropertyName("${jsonName}")]`)
if (member.deprecated)
out.push(`[System.Obsolete]`);
if (!type.endsWith('?') && !member.required) if (!type.endsWith('?') && !member.required)
type = `${type}?`; type = `${type}?`;
const requiredSuffix = type.endsWith('?') ? '' : ' = default!;'; const requiredSuffix = type.endsWith('?') ? '' : ' = default!;';
@ -678,6 +680,8 @@ function renderMethod(member, parent, name, options, out) {
out.push(...XmlDoc.renderXmlDoc(member.spec, maxDocumentationColumnWidth)); out.push(...XmlDoc.renderXmlDoc(member.spec, maxDocumentationColumnWidth));
paramDocs.forEach((value, i) => printArgDoc(i, value, out)); paramDocs.forEach((value, i) => printArgDoc(i, value, out));
} }
if(member.deprecated)
out.push(`[System.Obsolete]`);
out.push(`${modifiers}${type} ${toAsync(name, member.async)}(${args.join(', ')})${body}`); out.push(`${modifiers}${type} ${toAsync(name, member.async)}(${args.join(', ')})${body}`);
} else { } else {
let containsOptionalExplodedArgs = false; let containsOptionalExplodedArgs = false;