From 06e0ea5e2417443e9ea563463162fccfd494ebb4 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Mon, 3 Oct 2022 12:26:36 -0700
Subject: [PATCH] test: unflake page-drag tests (#17783)

To avoid rounding errors, make coordinates even.
---
 tests/assets/drag-n-drop.html |  3 ++
 tests/page/page-drag.spec.ts  | 86 +++++++++++++++++------------------
 2 files changed, 46 insertions(+), 43 deletions(-)

diff --git a/tests/assets/drag-n-drop.html b/tests/assets/drag-n-drop.html
index b73154a58f..f40b1bfc5d 100644
--- a/tests/assets/drag-n-drop.html
+++ b/tests/assets/drag-n-drop.html
@@ -1,4 +1,7 @@
 <style>
+* {
+  box-sizing: border-box;
+}
 body, html {
   margin: 0;
   padding: 0;
diff --git a/tests/page/page-drag.spec.ts b/tests/page/page-drag.spec.ts
index e41eabf8e1..b005288201 100644
--- a/tests/page/page-drag.spec.ts
+++ b/tests/page/page-drag.spec.ts
@@ -38,22 +38,22 @@ it.describe('Drag and drop', () => {
     await page.hover('#target');
     await page.mouse.up();
     expect(await events.jsonValue()).toEqual(browserName === 'firefox' ? [
-      'mousemove at 121;87',
-      'mousedown at 121;87',
-      'dragstart at 121;87',
-      'mousemove at 241;351',
+      'mousemove at 120;86',
+      'mousedown at 120;86',
+      'dragstart at 120;86',
+      'mousemove at 240;350',
       'dragenter at 0;0',
       'dragover at 0;0',
       'drop at 0;0',
       'dragend',
     ] : [
-      'mousemove at 121;87',
-      'mousedown at 121;87',
-      'mousemove at 241;351',
-      'dragstart at 121;87',
-      'dragenter at 241;351',
-      'dragover at 241;351',
-      'drop at 241;351',
+      'mousemove at 120;86',
+      'mousedown at 120;86',
+      'mousemove at 240;350',
+      'dragstart at 120;86',
+      'dragenter at 240;350',
+      'dragover at 240;350',
+      'drop at 240;350',
       'dragend',
     ]);
   });
@@ -67,17 +67,17 @@ it.describe('Drag and drop', () => {
     await page.mouse.down();
     await page.hover('#target');
     expect(await events.jsonValue()).toEqual(browserName === 'firefox' ? [
-      'mousemove at 121;87',
-      'mousedown at 121;87',
-      'dragstart at 121;87',
-      'mousemove at 241;351',
+      'mousemove at 120;86',
+      'mousedown at 120;86',
+      'dragstart at 120;86',
+      'mousemove at 240;350',
       'dragenter at 0;0',
     ] : [
-      'mousemove at 121;87',
-      'mousedown at 121;87',
-      'mousemove at 241;351',
-      'dragstart at 121;87',
-      'dragenter at 241;351',
+      'mousemove at 120;86',
+      'mousedown at 120;86',
+      'mousemove at 240;350',
+      'dragstart at 120;86',
+      'dragenter at 240;350',
     ]);
   });
 
@@ -98,22 +98,22 @@ it.describe('Drag and drop', () => {
     await page.mouse.up();
     expect(await frame.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(true); // could not find source in target
     expect(await frameEvents.jsonValue()).toEqual(browserName === 'firefox' ? [
-      'mousemove at 121;87',
-      'mousedown at 121;87',
-      'dragstart at 121;87',
-      'mousemove at 241;351',
+      'mousemove at 120;86',
+      'mousedown at 120;86',
+      'dragstart at 120;86',
+      'mousemove at 240;350',
       'dragenter at 0;0',
       'dragover at 0;0',
       'drop at 0;0',
       'dragend',
     ] : [
-      'mousemove at 121;87',
-      'mousedown at 121;87',
-      'mousemove at 241;351',
-      'dragstart at 121;87',
-      'dragenter at 241;351',
-      'dragover at 241;351',
-      'drop at 241;351',
+      'mousemove at 120;86',
+      'mousedown at 120;86',
+      'mousemove at 240;350',
+      'dragstart at 120;86',
+      'dragenter at 240;350',
+      'dragover at 240;350',
+      'drop at 240;350',
       'dragend',
     ]);
     expect(await pageEvents.jsonValue()).toEqual([]);
@@ -129,23 +129,23 @@ it.describe('Drag and drop', () => {
     await page.mouse.up();
     expect(await page.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(false); // found source in target
     expect(await events.jsonValue()).toEqual(browserName === 'firefox' ? [
-      'mousemove at 121;87',
-      'mousedown at 121;87',
-      'dragstart at 121;87',
-      'mousemove at 241;351',
+      'mousemove at 120;86',
+      'mousedown at 120;86',
+      'dragstart at 120;86',
+      'mousemove at 240;350',
       'dragenter at 0;0',
       'dragover at 0;0',
       'dragend',
-      'mouseup at 241;351',
+      'mouseup at 240;350',
     ] : [
-      'mousemove at 121;87',
-      'mousedown at 121;87',
-      'mousemove at 241;351',
-      'dragstart at 121;87',
-      'dragenter at 241;351',
-      browserName === 'chromium' ? null : 'dragover at 241;351',
+      'mousemove at 120;86',
+      'mousedown at 120;86',
+      'mousemove at 240;350',
+      'dragstart at 120;86',
+      'dragenter at 240;350',
+      browserName === 'chromium' ? null : 'dragover at 240;350',
       'dragend',
-      'mouseup at 241;351',
+      'mouseup at 240;350',
     ].filter(Boolean));
   });