From 071931ebb1f988291b522c6d201306b956612246 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Thu, 20 Aug 2020 16:51:17 -0700 Subject: [PATCH] feat(firefox): bump to 1166 (#3557) --- browsers.json | 2 +- src/firefox/protocol.ts | 19 +++++++++++++++++++ test/popup.spec.ts | 2 +- 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/browsers.json b/browsers.json index 648c1dbb03..874a9f03bc 100644 --- a/browsers.json +++ b/browsers.json @@ -8,7 +8,7 @@ }, { "name": "firefox", - "revision": "1160", + "revision": "1166", "download": true }, { diff --git a/src/firefox/protocol.ts b/src/firefox/protocol.ts index b521158ab2..01392eae62 100644 --- a/src/firefox/protocol.ts +++ b/src/firefox/protocol.ts @@ -262,6 +262,14 @@ export module Protocol { colorScheme: ("dark"|"light"|"no-preference")|null; }; export type setColorSchemeReturnValue = void; + export type setScreencastOptionsParameters = { + browserContextId?: string; + dir: string; + width: number; + height: number; + scale?: number; + }; + export type setScreencastOptionsReturnValue = void; } export module Page { export type DOMPoint = { @@ -398,6 +406,13 @@ export module Protocol { workerId: string; message: string; } + export type screencastStartedPayload = { + uid: string; + file: string; + } + export type screencastStoppedPayload = { + uid: string; + } export type closeParameters = { runBeforeUnload?: boolean; }; @@ -935,6 +950,8 @@ export module Protocol { "Page.workerCreated": Page.workerCreatedPayload; "Page.workerDestroyed": Page.workerDestroyedPayload; "Page.dispatchMessageFromWorker": Page.dispatchMessageFromWorkerPayload; + "Page.screencastStarted": Page.screencastStartedPayload; + "Page.screencastStopped": Page.screencastStoppedPayload; "Runtime.executionContextCreated": Runtime.executionContextCreatedPayload; "Runtime.executionContextDestroyed": Runtime.executionContextDestroyedPayload; "Runtime.console": Runtime.consolePayload; @@ -974,6 +991,7 @@ export module Protocol { "Browser.getCookies": Browser.getCookiesParameters; "Browser.setOnlineOverride": Browser.setOnlineOverrideParameters; "Browser.setColorScheme": Browser.setColorSchemeParameters; + "Browser.setScreencastOptions": Browser.setScreencastOptionsParameters; "Page.close": Page.closeParameters; "Page.setFileInputFiles": Page.setFileInputFilesParameters; "Page.addBinding": Page.addBindingParameters; @@ -1046,6 +1064,7 @@ export module Protocol { "Browser.getCookies": Browser.getCookiesReturnValue; "Browser.setOnlineOverride": Browser.setOnlineOverrideReturnValue; "Browser.setColorScheme": Browser.setColorSchemeReturnValue; + "Browser.setScreencastOptions": Browser.setScreencastOptionsReturnValue; "Page.close": Page.closeReturnValue; "Page.setFileInputFiles": Page.setFileInputFilesReturnValue; "Page.addBinding": Page.addBindingReturnValue; diff --git a/test/popup.spec.ts b/test/popup.spec.ts index 7bc3097ac0..4ca24a2ac4 100644 --- a/test/popup.spec.ts +++ b/test/popup.spec.ts @@ -233,7 +233,7 @@ it('should not dispatch binding on a closed page', async function({browser, serv ]); await context.close(); if (options.FIREFOX) - expect(messages.join('|')).toBe('alreadyclosed'); + expect(messages.join('|')).toBe('close'); else expect(messages.join('|')).toBe('binding|close'); });