From 0869195ba46e5c78440b455a3f9fca951a2a04d8 Mon Sep 17 00:00:00 2001 From: Julian Descottes Date: Wed, 15 Jan 2025 00:27:49 +0100 Subject: [PATCH] chore(bidi): Stop dividing BiDi network event timings by 1000 (#34324) --- .../playwright-core/src/server/bidi/bidiNetworkManager.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/playwright-core/src/server/bidi/bidiNetworkManager.ts b/packages/playwright-core/src/server/bidi/bidiNetworkManager.ts index 88eaf54fbe..c46ce90307 100644 --- a/packages/playwright-core/src/server/bidi/bidiNetworkManager.ts +++ b/packages/playwright-core/src/server/bidi/bidiNetworkManager.ts @@ -96,10 +96,10 @@ export class BidiNetworkManager { function relativeToStart(time: number): number { if (!time) return -1; - return (time - startTime) / 1000; + return (time - startTime); } const timing: network.ResourceTiming = { - startTime: startTime / 1000, + startTime: startTime, requestStart: relativeToStart(timings.requestStart), responseStart: relativeToStart(timings.responseStart), domainLookupStart: relativeToStart(timings.dnsStart), @@ -130,7 +130,7 @@ export class BidiNetworkManager { // Keep redirected requests in the map for future reference as redirectedFrom. const isRedirected = response.status() >= 300 && response.status() <= 399; - const responseEndTime = params.request.timings.responseEnd / 1000 - response.timing().startTime; + const responseEndTime = params.request.timings.responseEnd - response.timing().startTime; if (isRedirected) { response._requestFinished(responseEndTime); } else {