Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: unflake more cookies tests (#2333)

Browse source 
This is addressing a possible race between setting document.cookie and
cookies appearing in out-of-process cookie jar.
This commit is contained in:
Dmitry Gozman 2020-05-21 15:37:52 -07:00 committed by GitHub
parent aae3f1e75d
commit 0a8fa6e46c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
test/cookies.spec.js
View file

@ -23,9 +23,11 @@ describe('BrowserContext.cookies', function() {
});
it('should get a cookie', async({context, page, server}) => {
await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => {
const documentCookie = await page.evaluate(() => {
document.cookie = 'username=John Doe';
return document.cookie;
});
expect(documentCookie).toBe('username=John Doe');
expect(await context.cookies()).toEqual([{
name: 'username',
value: 'John Doe',
@ -41,10 +43,12 @@ describe('BrowserContext.cookies', function() {
await page.goto(server.EMPTY_PAGE);
// @see https://en.wikipedia.org/wiki/Year_2038_problem
const date = +(new Date('1/1/2038'));
await page.evaluate(timestamp => {
const documentCookie = await page.evaluate(timestamp => {
const date = new Date(timestamp);
document.cookie = `username=John Doe;expires=${date.toUTCString()}`;
return document.cookie;
}, date);
expect(documentCookie).toBe('username=John Doe');
expect(await context.cookies()).toEqual([{
name: 'username',
value: 'John Doe',
@ -171,10 +175,12 @@ describe('BrowserContext.addCookies', function() {
await page.goto(server.EMPTY_PAGE);
// @see https://en.wikipedia.org/wiki/Year_2038_problem
const date = +(new Date('1/1/2038'));
await page.evaluate(timestamp => {
const documentCookie = await page.evaluate(timestamp => {
const date = new Date(timestamp);
document.cookie = `username=John Doe;expires=${date.toUTCString()}`;
return document.cookie;
}, date);
expect(documentCookie).toBe('username=John Doe');
const cookies = await context.cookies();
await context.clearCookies();
expect(await context.cookies()).toEqual([]);