From 0ac18dc18c30034a10822789a44d41de4a7ee468 Mon Sep 17 00:00:00 2001
From: Henrik Skupin <mail@hskupin.info>
Date: Fri, 10 Jan 2025 14:57:54 +0100
Subject: [PATCH] chore(bidi): fix invocation of getBidiKeyValue for keyup and
 add support for "Space"

---
 packages/playwright-core/src/server/bidi/bidiInput.ts           | 2 +-
 .../playwright-core/src/server/bidi/third_party/bidiKeyboard.ts | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/packages/playwright-core/src/server/bidi/bidiInput.ts b/packages/playwright-core/src/server/bidi/bidiInput.ts
index 5266fef023..01b773178d 100644
--- a/packages/playwright-core/src/server/bidi/bidiInput.ts
+++ b/packages/playwright-core/src/server/bidi/bidiInput.ts
@@ -40,7 +40,7 @@ export class RawKeyboardImpl implements input.RawKeyboard {
 
   async keyup(modifiers: Set<types.KeyboardModifier>, code: string, keyCode: number, keyCodeWithoutLocation: number, key: string, location: number): Promise<void> {
     const actions: bidi.Input.KeySourceAction[] = [];
-    actions.push({ type: 'keyUp', value: getBidiKeyValue(key) });
+    actions.push({ type: 'keyUp', value: getBidiKeyValue(code) });
     await this._performActions(actions);
   }
 
diff --git a/packages/playwright-core/src/server/bidi/third_party/bidiKeyboard.ts b/packages/playwright-core/src/server/bidi/third_party/bidiKeyboard.ts
index 2b07c281ab..c2d60ff66b 100644
--- a/packages/playwright-core/src/server/bidi/third_party/bidiKeyboard.ts
+++ b/packages/playwright-core/src/server/bidi/third_party/bidiKeyboard.ts
@@ -131,6 +131,8 @@ export const getBidiKeyValue = (code: string) => {
       return '\uE052';
     case 'MetaRight':
       return '\uE053';
+    case 'Space':
+      return ' ';
     case 'Digit0':
       return '0';
     case 'Digit1':