Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Use # insted of @

Browse source
This commit is contained in:
Yury Semikhatsky 2024-05-14 16:33:37 -07:00
parent cb0648040c
commit 0b6ac63202
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/trace-viewer/src/ui/networkTab.tsx
View file

@ -133,6 +133,8 @@ const columnWidth = (column: ColumnName) => {
return 60; return 60;
if (column === 'contentType') if (column === 'contentType')
return 200; return 200;
if (column === 'contextId')
return 60;
return 100; return 100;
}; };
@ -210,7 +212,7 @@ class ContextIdGenerator {
let shortId = this._pagerefToShortId.get(pageref); let shortId = this._pagerefToShortId.get(pageref);
if (!shortId) { if (!shortId) {
++this._lastPageId; ++this._lastPageId;
shortId = 'page@' + this._lastPageId; shortId = 'page#' + this._lastPageId;
this._pagerefToShortId.set(pageref, shortId); this._pagerefToShortId.set(pageref, shortId);
} }
return shortId; return shortId;
@ -223,7 +225,7 @@ class ContextIdGenerator {
let contextId = (contextEntry as any)[ContextIdGenerator._apiRequestContextIdSymbol]; let contextId = (contextEntry as any)[ContextIdGenerator._apiRequestContextIdSymbol];
if (!contextId) { if (!contextId) {
++this._lastApiRequestContextId; ++this._lastApiRequestContextId;
contextId = 'api@' + this._lastApiRequestContextId; contextId = 'api#' + this._lastApiRequestContextId;
(contextEntry as any)[ContextIdGenerator._apiRequestContextIdSymbol] = contextId; (contextEntry as any)[ContextIdGenerator._apiRequestContextIdSymbol] = contextId;
} }
return contextId; return contextId;

6
tests/playwright-test/ui-mode-trace.spec.ts
View file

@ -302,7 +302,7 @@ test('should show request source context id', async ({ runUITest, server }) => {
await page.getByText('pass').dblclick(); await page.getByText('pass').dblclick();
await page.getByText('Network', { exact: true }).click(); await page.getByText('Network', { exact: true }).click();
await expect(page.locator('span').filter({ hasText: 'Source' })).toBeVisible(); await expect(page.locator('span').filter({ hasText: 'Source' })).toBeVisible();
await expect(page.getByText('page@1')).toBeVisible(); await expect(page.getByText('page#1')).toBeVisible();
await expect(page.getByText('page@2')).toBeVisible(); await expect(page.getByText('page#2')).toBeVisible();
await expect(page.getByText('api@1')).toBeVisible(); await expect(page.getByText('api#1')).toBeVisible();
}); });