From 0bf635ecce5455467295552c1565eca10941cda3 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Tue, 26 Mar 2024 09:20:13 -0700 Subject: [PATCH] chore: ensure max failures exit yields erroneous status code (#30120) Fixes https://github.com/microsoft/playwright/issues/30118 --- packages/playwright/src/runner/dispatcher.ts | 7 ------- packages/playwright/src/runner/failureTracker.ts | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/packages/playwright/src/runner/dispatcher.ts b/packages/playwright/src/runner/dispatcher.ts index da2b759aa6..9fdb620f2c 100644 --- a/packages/playwright/src/runner/dispatcher.ts +++ b/packages/playwright/src/runner/dispatcher.ts @@ -229,13 +229,6 @@ export class Dispatcher { await Promise.all(this._workerSlots.map(({ worker }) => worker?.stop())); this._checkFinished(); } - - private _reportTestEnd(test: TestCase, result: TestResult) { - this._reporter.onTestEnd(test, result); - this._failureTracker.onTestEnd(test, result); - if (this._failureTracker.hasReachedMaxFailures()) - this.stop().catch(e => {}); - } } class JobDispatcher { diff --git a/packages/playwright/src/runner/failureTracker.ts b/packages/playwright/src/runner/failureTracker.ts index fc2202b3ea..eb39b1d44f 100644 --- a/packages/playwright/src/runner/failureTracker.ts +++ b/packages/playwright/src/runner/failureTracker.ts @@ -49,6 +49,6 @@ export class FailureTracker { } result(): 'failed' | 'passed' { - return this._hasWorkerErrors || this._rootSuite?.allTests().some(test => !test.ok()) ? 'failed' : 'passed'; + return this._hasWorkerErrors || this.hasReachedMaxFailures() || this._rootSuite?.allTests().some(test => !test.ok()) ? 'failed' : 'passed'; } }