Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

made changes according to review comments

Browse source
This commit is contained in:
GeneratorX16 2025-02-11 23:19:28 +05:30
parent 7ad93b85b6
commit 0c16899ec7
2 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/web/src/components/treeView.css
View file

@ -70,10 +70,8 @@
} }
.tree-view-content:focus .tree-view-entry.selected button.eye.toggled { .tree-view-content:focus .tree-view-entry.selected button.eye.toggled {
color: var(--vscode-button-secondaryForeground) !important; border-radius: 6px;
border-radius: 5px; outline: 1px solid var(--vscode-button-foreground);
margin: -1px;
border: 1px inset var(--vscode-button-foreground);
} }
.tree-view-empty { .tree-view-empty {

16
tests/playwright-test/ui-mode-test-watch.spec.ts
View file

@ -330,16 +330,22 @@ test('should have watch icon highlighted when a test is focused and watch on the
`, `,
}); });
await page.getByText('a.test.ts').click(); await page.getByTestId('test-tree').getByText('a.test.ts').click();
// watch icon should not be highlight till the watch icon is clicked // watch icon should not be highlight till the watch icon is clicked
await page.getByRole('treeitem', { name: 'passes' }).hover(); await page.getByRole('treeitem', { name: 'passes' }).hover();
await expect(page.getByRole('treeitem', { name: 'passes' }).getByRole('button', { name: 'Watch' })).not.toHaveCSS('border', '1px inset rgb(255, 255, 255)'); await expect(page.getByRole('treeitem', { name: 'passes' }).getByRole('button', { name: 'Watch' })).not.toHaveCSS('outline', 'rgb(255, 255, 255) solid 1px');
await page.getByRole('treeitem', { name: 'passes' }).getByRole('button', { name: 'Watch' }).click(); await page.getByRole('treeitem', { name: 'passes' }).getByRole('button', { name: 'Watch' }).click();
await expect(page.getByRole('treeitem', { name: 'passes' }).getByRole('button', { name: 'Watch' }).locator('.codicon-eye')).toHaveCSS('color', 'rgb(255, 255, 255)'); await expect(page.getByRole('treeitem', { name: 'passes' }).getByRole('button', { name: 'Watch' }).locator('.codicon-eye')).toHaveCSS('color', 'rgb(255, 255, 255)');
await expect(page.getByRole('treeitem', { name: 'passes' }).getByRole('button', { name: 'Watch' })).toHaveCSS('border', '1px inset rgb(255, 255, 255)'); await expect(page.getByRole('treeitem', { name: 'passes' }).getByRole('button', { name: 'Watch' })).toHaveCSS('outline', 'rgb(255, 255, 255) solid 1px');
// deselection of the tree-row should still show the watch icon when watch on tree row is active
await page.getByTestId('test-tree').getByText('a.test.ts').click();
await expect(page.getByRole('treeitem', { name: 'passes' }).getByRole('button', { name: 'Watch' })).toBeVisible();
await expect(page.getByRole('treeitem', { name: 'passes' }).getByRole('button', { name: 'Watch' })).not.toHaveCSS('outline', 'rgb(255, 255, 255) solid 1px');
await expect.poll(dumpTestTree(page)).toBe(` await expect.poll(dumpTestTree(page)).toBe(`
▼ ◯ a.test.ts ▼ ◯ a.test.ts <=
◯ passes 👁 <= ◯ passes 👁
`); `);
}); });