Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: hide 'Open in VSCode' for folders in UI Mode (#23499)

Browse source
This commit is contained in:
Max Schmitt 2023-06-05 22:09:45 +02:00 committed by GitHub
parent afa531ef60
commit 0e12831a02
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/trace-viewer/src/ui/uiModeView.tsx
View file

@ -452,7 +452,7 @@ const TestList: React.FC<{
{!!treeItem.duration && treeItem.status !== 'skipped' && <div className='ui-mode-list-item-time'>{msToString(treeItem.duration)}</div>} {!!treeItem.duration && treeItem.status !== 'skipped' && <div className='ui-mode-list-item-time'>{msToString(treeItem.duration)}</div>}
<Toolbar noMinHeight={true} noShadow={true}> <Toolbar noMinHeight={true} noShadow={true}>
<ToolbarButton icon='play' title='Run' onClick={() => runTreeItem(treeItem)} disabled={!!runningState}></ToolbarButton> <ToolbarButton icon='play' title='Run' onClick={() => runTreeItem(treeItem)} disabled={!!runningState}></ToolbarButton>
<ToolbarButton icon='go-to-file' title='Open in VS Code' onClick={() => sendMessageNoReply('open', { location: locationToOpen(treeItem) })}></ToolbarButton> <ToolbarButton icon='go-to-file' title='Open in VS Code' onClick={() => sendMessageNoReply('open', { location: locationToOpen(treeItem) })} style={(treeItem.kind === 'group' && treeItem.subKind === 'folder') ? { visibility: 'hidden' } : {}}></ToolbarButton>
{!watchAll && <ToolbarButton icon='eye' title='Watch' onClick={() => { {!watchAll && <ToolbarButton icon='eye' title='Watch' onClick={() => {
if (watchedTreeIds.value.has(treeItem.id)) if (watchedTreeIds.value.has(treeItem.id))
watchedTreeIds.value.delete(treeItem.id); watchedTreeIds.value.delete(treeItem.id);

6
packages/web/src/components/toolbarButton.tsx
View file

@ -24,6 +24,7 @@ export interface ToolbarButtonProps {
disabled?: boolean, disabled?: boolean,
toggled?: boolean, toggled?: boolean,
onClick: () => void, onClick: () => void,
style?: React.CSSProperties
} }
export const ToolbarButton: React.FC<React.PropsWithChildren<ToolbarButtonProps>> = ({ export const ToolbarButton: React.FC<React.PropsWithChildren<ToolbarButtonProps>> = ({
@ -33,6 +34,7 @@ export const ToolbarButton: React.FC<React.PropsWithChildren<ToolbarButtonProps>
disabled = false, disabled = false,
toggled = false, toggled = false,
onClick = () => {}, onClick = () => {},
style,
}) => { }) => {
let className = `toolbar-button ${icon}`; let className = `toolbar-button ${icon}`;
if (toggled) if (toggled)
@ -43,7 +45,9 @@ export const ToolbarButton: React.FC<React.PropsWithChildren<ToolbarButtonProps>
onClick={onClick} onClick={onClick}
onDoubleClick={preventDefault} onDoubleClick={preventDefault}
title={title} title={title}
disabled={!!disabled}> disabled={!!disabled}
style={style}
>
{icon && <span className={`codicon codicon-${icon}`} style={children ? { marginRight: 5 } : {}}></span>} {icon && <span className={`codicon codicon-${icon}`} style={children ? { marginRight: 5 } : {}}></span>}
{children} {children}
</button>; </button>;