From 0fa8073ab653487e7220de58b2f41559f9c8ca85 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Thu, 11 Nov 2021 10:23:00 -0800 Subject: [PATCH] browser(firefox): fix input composition when TIP is stolen by user (#10238) When firefox is automated + interacted with manually, input composition might get stolen from Text Input Processor. Re-requiring TIP every time seems to fix this. References #5460 --- browser_patches/firefox-beta/BUILD_NUMBER | 4 ++-- browser_patches/firefox-beta/juggler/content/FrameTree.js | 2 +- browser_patches/firefox/BUILD_NUMBER | 2 +- browser_patches/firefox/juggler/content/FrameTree.js | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/browser_patches/firefox-beta/BUILD_NUMBER b/browser_patches/firefox-beta/BUILD_NUMBER index e580183020..fa1cb8949a 100644 --- a/browser_patches/firefox-beta/BUILD_NUMBER +++ b/browser_patches/firefox-beta/BUILD_NUMBER @@ -1,2 +1,2 @@ -1303 -Changed: yurys@chromium.org Thu 04 Nov 2021 12:26:04 PM PDT +1304 +Changed: aslushnikov@gmail.com Wed Nov 10 21:36:03 HST 2021 diff --git a/browser_patches/firefox-beta/juggler/content/FrameTree.js b/browser_patches/firefox-beta/juggler/content/FrameTree.js index 928ad67def..ccb49bf4e2 100644 --- a/browser_patches/firefox-beta/juggler/content/FrameTree.js +++ b/browser_patches/firefox-beta/juggler/content/FrameTree.js @@ -522,8 +522,8 @@ class Frame { textInputProcessor() { if (!this._textInputProcessor) { this._textInputProcessor = Cc["@mozilla.org/text-input-processor;1"].createInstance(Ci.nsITextInputProcessor); - this._textInputProcessor.beginInputTransactionForTests(this._docShell.DOMWindow); } + this._textInputProcessor.beginInputTransactionForTests(this._docShell.DOMWindow); return this._textInputProcessor; } diff --git a/browser_patches/firefox/BUILD_NUMBER b/browser_patches/firefox/BUILD_NUMBER index 55030b3878..3e4dd69e56 100644 --- a/browser_patches/firefox/BUILD_NUMBER +++ b/browser_patches/firefox/BUILD_NUMBER @@ -1,2 +1,2 @@ 1304 -Changed: lushnikov@chromium.org Fri Nov 5 12:27:32 HST 2021 +Changed: lushnikov@chromium.org Wed Nov 10 21:36:03 HST 2021 diff --git a/browser_patches/firefox/juggler/content/FrameTree.js b/browser_patches/firefox/juggler/content/FrameTree.js index 928ad67def..ccb49bf4e2 100644 --- a/browser_patches/firefox/juggler/content/FrameTree.js +++ b/browser_patches/firefox/juggler/content/FrameTree.js @@ -522,8 +522,8 @@ class Frame { textInputProcessor() { if (!this._textInputProcessor) { this._textInputProcessor = Cc["@mozilla.org/text-input-processor;1"].createInstance(Ci.nsITextInputProcessor); - this._textInputProcessor.beginInputTransactionForTests(this._docShell.DOMWindow); } + this._textInputProcessor.beginInputTransactionForTests(this._docShell.DOMWindow); return this._textInputProcessor; }