}
runTests('bounce-if-busy', visibleTestIds)} disabled={isRunningTest || isLoading}>
- testServerConnection?.stopTests()} disabled={!isRunningTest || isLoading}>
+ testServerConnection?.stopTests({})} disabled={!isRunningTest || isLoading}> {
setWatchedTreeIds({ value: new Set() });
setWatchAll(!watchAll);
From 1539cde0343a19bfa590478cb13bb9aeff905180 Mon Sep 17 00:00:00 2001
From: Pavel Feldman
Date: Fri, 22 Mar 2024 16:04:59 -0700
Subject: [PATCH 11/29] chore: allow passing path to config to the test server
(#30068)
---
packages/playwright/src/program.ts | 1 +
packages/playwright/src/runner/testServer.ts | 8 ++++----
tests/playwright-test/ui-mode-test-setup.spec.ts | 7 +++++--
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/packages/playwright/src/program.ts b/packages/playwright/src/program.ts
index d16a47d4e6..dbae2f693b 100644
--- a/packages/playwright/src/program.ts
+++ b/packages/playwright/src/program.ts
@@ -108,6 +108,7 @@ function addFindRelatedTestFilesCommand(program: Command) {
function addTestServerCommand(program: Command) {
const command = program.command('test-server', { hidden: true });
command.description('start test server');
+ command.option('-c, --config ', `Configuration file, or a test directory with optional "playwright.config.{m,c}?{js,ts}"`);
command.option('--host ', 'Host to start the server on', 'localhost');
command.option('--port ', 'Port to start the server on', '0');
command.action(opts => runTestServer(opts));
diff --git a/packages/playwright/src/runner/testServer.ts b/packages/playwright/src/runner/testServer.ts
index 33cc6e4f9e..d100e04983 100644
--- a/packages/playwright/src/runner/testServer.ts
+++ b/packages/playwright/src/runner/testServer.ts
@@ -24,7 +24,7 @@ import { collectAffectedTestFiles, dependenciesForTestFile } from '../transform/
import type { FullConfigInternal } from '../common/config';
import { InternalReporter } from '../reporters/internalReporter';
import { createReporterForTestServer, createReporters } from './reporters';
-import { TestRun, createTaskRunnerForList, createTaskRunnerForWatch, createTaskRunnerForWatchSetup } from './tasks';
+import { TestRun, createTaskRunnerForList, createTaskRunnerForTestServer, createTaskRunnerForWatchSetup } from './tasks';
import { open } from 'playwright-core/lib/utilsBundle';
import ListReporter from '../reporters/list';
import { Multiplexer } from '../reporters/multiplexer';
@@ -97,7 +97,7 @@ class TestServerDispatcher implements TestServerInterface {
this._configFile = configFile;
this.transport = {
dispatch: (method, params) => (this as any)[method](params),
- onclose: () => {},
+ onclose: () => gracefullyProcessExitDoNotHang(0),
};
this._globalWatcher = new Watcher('deep', () => this._dispatchEvent('listChanged', {}));
this._testWatcher = new Watcher('flat', events => {
@@ -238,7 +238,7 @@ class TestServerDispatcher implements TestServerInterface {
timeout: params.timeout,
reporter: params.reporters ? params.reporters.map(r => [r]) : undefined,
use: {
- trace: params.trace === 'on' ? { mode: 'on', sources: false, _live: true } : undefined,
+ trace: params.trace === 'on' ? { mode: 'on', sources: false, _live: true } : (params.trace === 'off' ? 'off' : undefined),
headless: params.headed ? false : undefined,
_optionContextReuseMode: params.reuseContext ? 'when-possible' : undefined,
_optionConnectOptions: params.connectWsEndpoint ? { wsEndpoint: params.connectWsEndpoint } : undefined,
@@ -263,7 +263,7 @@ class TestServerDispatcher implements TestServerInterface {
const reporters = await createReporters(config, 'test', true);
reporters.push(await createReporterForTestServer(config, 'test', params.serializer || require.resolve('./uiModeReporter'), e => this._dispatchEvent('report', e)));
const reporter = new InternalReporter(new Multiplexer(reporters));
- const taskRunner = createTaskRunnerForWatch(config, reporter);
+ const taskRunner = createTaskRunnerForTestServer(config, reporter);
const testRun = new TestRun(config, reporter);
reporter.onConfigure(config.config);
const stop = new ManualPromise();
diff --git a/tests/playwright-test/ui-mode-test-setup.spec.ts b/tests/playwright-test/ui-mode-test-setup.spec.ts
index 4def43d078..7a5ce3f084 100644
--- a/tests/playwright-test/ui-mode-test-setup.spec.ts
+++ b/tests/playwright-test/ui-mode-test-setup.spec.ts
@@ -50,8 +50,10 @@ test('should run global setup and teardown', async ({ runUITest }) => {
]);
});
-test('should teardown on sigint', async ({ runUITest }) => {
+test('should teardown on sigint', async ({ runUITest, nodeVersion }) => {
test.skip(process.platform === 'win32', 'No sending SIGINT on Windows');
+ test.skip(nodeVersion.major < 18);
+
const { page, testProcess } = await runUITest({
'playwright.config.ts': `
import { defineConfig } from '@playwright/test';
@@ -201,8 +203,9 @@ test('should run part of the setup only', async ({ runUITest }) => {
for (const useWeb of [true, false]) {
test.describe(`web-mode: ${useWeb}`, () => {
- test('should run teardown with SIGINT', async ({ runUITest }) => {
+ test('should run teardown with SIGINT', async ({ runUITest, nodeVersion }) => {
test.skip(process.platform === 'win32', 'No sending SIGINT on Windows');
+ test.skip(nodeVersion.major < 18);
const { page, testProcess } = await runUITest({
'playwright.config.ts': `
import { defineConfig } from '@playwright/test';
From 7a3c00294457f17f568d992b8993f1332fb3a792 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman
Date: Mon, 25 Mar 2024 07:41:54 -0700
Subject: [PATCH 12/29] fix(ct): allow importing json files (#30067)
While we are not fully resolving imports during compilation, do not
treat `json` as a non-importable asset.
Fixes #29926.
---
.../playwright-ct-core/src/tsxTransform.ts | 5 +----
.../playwright.ct-build.spec.ts | 18 ++++++++++++++++++
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/packages/playwright-ct-core/src/tsxTransform.ts b/packages/playwright-ct-core/src/tsxTransform.ts
index ab33c114ba..a01bfdfa63 100644
--- a/packages/playwright-ct-core/src/tsxTransform.ts
+++ b/packages/playwright-ct-core/src/tsxTransform.ts
@@ -193,7 +193,4 @@ const artifactExtensions = new Set([
'.ttf',
'.otf',
'.eot',
-
- // Other assets
- '.json',
-]);
\ No newline at end of file
+]);
diff --git a/tests/playwright-test/playwright.ct-build.spec.ts b/tests/playwright-test/playwright.ct-build.spec.ts
index 38bae33604..aa053a6d8b 100644
--- a/tests/playwright-test/playwright.ct-build.spec.ts
+++ b/tests/playwright-test/playwright.ct-build.spec.ts
@@ -497,6 +497,24 @@ test('should render component via re-export', async ({ runInlineTest }, testInfo
expect(result.passed).toBe(1);
});
+test('should import json', async ({ runInlineTest }) => {
+ const result = await runInlineTest({
+ 'playwright.config.ts': playwrightCtConfigText,
+ 'playwright/index.html': ``,
+ 'playwright/index.ts': ``,
+ 'src/some.json': `{ "some": "value" }`,
+ 'src/button.test.tsx': `
+ import { test, expect } from '@playwright/experimental-ct-react';
+ import json from './some.json';
+ test('pass', async ({}) => {
+ expect(json.some).toBe('value');
+ });
+ `,
+ }, { workers: 1 });
+ expect(result.exitCode).toBe(0);
+ expect(result.passed).toBe(1);
+});
+
test('should render component exported via fixture', async ({ runInlineTest }, testInfo) => {
const result = await runInlineTest({
'playwright.config.ts': playwrightCtConfigText,
From 95d649b406006f950f9a265ec061fdcf435d10a2 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman
Date: Mon, 25 Mar 2024 07:42:13 -0700
Subject: [PATCH 13/29] feat: address api review feedback for 1.43 (#30066)
- Update docs for `trace: retain-on-first-failure`.
- Update docs for `devtools` option.
- Rename `Locator.enterFrame()` to `Locator.contentFrame()`.
- Rename `FrameLocator.exitFrame()` to `FrameLocator.owner()`.
---
docs/src/api/class-framelocator.md | 98 +++++++++--------
docs/src/api/class-locator.md | 14 ++-
docs/src/api/params.md | 5 +-
docs/src/test-api/class-testoptions.md | 6 +-
.../playwright-core/src/client/locator.ts | 4 +-
packages/playwright-core/types/types.d.ts | 103 ++++++++++--------
packages/playwright/types/test.d.ts | 7 +-
tests/page/locator-frame.spec.ts | 8 +-
8 files changed, 130 insertions(+), 115 deletions(-)
diff --git a/docs/src/api/class-framelocator.md b/docs/src/api/class-framelocator.md
index cf75fc8422..320ad36ba2 100644
--- a/docs/src/api/class-framelocator.md
+++ b/docs/src/api/class-framelocator.md
@@ -74,57 +74,11 @@ await page.FrameLocator(".result-frame").First.getByRole(AriaRole.Button).ClickA
**Converting Locator to FrameLocator**
-If you have a [Locator] object pointing to an `iframe` it can be converted to [FrameLocator] using [`method: Locator.enterFrame`].
+If you have a [Locator] object pointing to an `iframe` it can be converted to [FrameLocator] using [`method: Locator.contentFrame`].
**Converting FrameLocator to Locator**
-If you have a [FrameLocator] object it can be converted to [Locator] pointing to the same `iframe` using [`method: FrameLocator.exitFrame`].
-
-
-## method: FrameLocator.exitFrame
-* since: v1.43
-- returns: <[Locator]>
-
-Returns a [Locator] object pointing to the same `iframe` as this frame locator.
-
-Useful when you have a [FrameLocator] object obtained somewhere, and later on would like to interact with the `iframe` element.
-
-**Usage**
-
-```js
-const frameLocator = page.frameLocator('iframe[name="embedded"]');
-// ...
-const locator = frameLocator.exitFrame();
-await expect(locator).toBeVisible();
-```
-
-```java
-FrameLocator frameLocator = page.frameLocator("iframe[name=\"embedded\"]");
-// ...
-Locator locator = frameLocator.exitFrame();
-assertThat(locator).isVisible();
-```
-
-```python async
-frame_locator = page.frame_locator("iframe[name=\"embedded\"]")
-# ...
-locator = frame_locator.exit_frame
-await expect(locator).to_be_visible()
-```
-
-```python sync
-frame_locator = page.frame_locator("iframe[name=\"embedded\"]")
-# ...
-locator = frame_locator.exit_frame
-expect(locator).to_be_visible()
-```
-
-```csharp
-var frameLocator = Page.FrameLocator("iframe[name=\"embedded\"]");
-// ...
-var locator = frameLocator.ExitFrame;
-await Expect(locator).ToBeVisibleAsync();
-```
+If you have a [FrameLocator] object it can be converted to [Locator] pointing to the same `iframe` using [`method: FrameLocator.owner`].
## method: FrameLocator.first
@@ -248,3 +202,51 @@ Returns locator to the n-th matching frame. It's zero based, `nth(0)` selects th
### param: FrameLocator.nth.index
* since: v1.17
- `index` <[int]>
+
+## method: FrameLocator.owner
+* since: v1.43
+- returns: <[Locator]>
+
+Returns a [Locator] object pointing to the same `iframe` as this frame locator.
+
+Useful when you have a [FrameLocator] object obtained somewhere, and later on would like to interact with the `iframe` element.
+
+For a reverse operation, use [`method: Locator.contentFrame`].
+
+**Usage**
+
+```js
+const frameLocator = page.frameLocator('iframe[name="embedded"]');
+// ...
+const locator = frameLocator.owner();
+await expect(locator).toBeVisible();
+```
+
+```java
+FrameLocator frameLocator = page.frameLocator("iframe[name=\"embedded\"]");
+// ...
+Locator locator = frameLocator.owner();
+assertThat(locator).isVisible();
+```
+
+```python async
+frame_locator = page.frame_locator("iframe[name=\"embedded\"]")
+# ...
+locator = frame_locator.owner
+await expect(locator).to_be_visible()
+```
+
+```python sync
+frame_locator = page.frame_locator("iframe[name=\"embedded\"]")
+# ...
+locator = frame_locator.owner
+expect(locator).to_be_visible()
+```
+
+```csharp
+var frameLocator = Page.FrameLocator("iframe[name=\"embedded\"]");
+// ...
+var locator = frameLocator.Owner;
+await Expect(locator).ToBeVisibleAsync();
+```
+
diff --git a/docs/src/api/class-locator.md b/docs/src/api/class-locator.md
index c254adc1c0..50ef738c9a 100644
--- a/docs/src/api/class-locator.md
+++ b/docs/src/api/class-locator.md
@@ -747,7 +747,7 @@ Resolves given locator to the first matching DOM element. If there are no matchi
Resolves given locator to all matching DOM elements. If there are no matching elements, returns an empty list.
-## method: Locator.enterFrame
+## method: Locator.contentFrame
* since: v1.43
- returns: <[FrameLocator]>
@@ -755,40 +755,42 @@ Returns a [FrameLocator] object pointing to the same `iframe` as this locator.
Useful when you have a [Locator] object obtained somewhere, and later on would like to interact with the content inside the frame.
+For a reverse operation, use [`method: FrameLocator.owner`].
+
**Usage**
```js
const locator = page.locator('iframe[name="embedded"]');
// ...
-const frameLocator = locator.enterFrame();
+const frameLocator = locator.contentFrame();
await frameLocator.getByRole('button').click();
```
```java
Locator locator = page.locator("iframe[name=\"embedded\"]");
// ...
-FrameLocator frameLocator = locator.enterFrame();
+FrameLocator frameLocator = locator.contentFrame();
frameLocator.getByRole(AriaRole.BUTTON).click();
```
```python async
locator = page.locator("iframe[name=\"embedded\"]")
# ...
-frame_locator = locator.enter_frame
+frame_locator = locator.content_frame
await frame_locator.get_by_role("button").click()
```
```python sync
locator = page.locator("iframe[name=\"embedded\"]")
# ...
-frame_locator = locator.enter_frame
+frame_locator = locator.content_frame
frame_locator.get_by_role("button").click()
```
```csharp
var locator = Page.Locator("iframe[name=\"embedded\"]");
// ...
-var frameLocator = locator.EnterFrame;
+var frameLocator = locator.ContentFrame;
await frameLocator.GetByRole(AriaRole.Button).ClickAsync();
```
diff --git a/docs/src/api/params.md b/docs/src/api/params.md
index e3b2894c3c..e33cd7d664 100644
--- a/docs/src/api/params.md
+++ b/docs/src/api/params.md
@@ -999,10 +999,11 @@ disable timeout.
If specified, traces are saved into this directory.
## browser-option-devtools
-* deprecated: Use [debugging tools](../debug.md) instead.
- `devtools` <[boolean]>
-**Chromium-only** Whether to auto-open a Developer Tools panel for each tab. If this option is `true`, the
+**Deprecated, Chromium-only.** Use [debugging tools](../debug.md) instead.
+
+Whether to auto-open a Developer Tools panel for each tab. If this option is `true`, the
[`option: headless`] option will be set `false`.
## browser-option-slowmo
diff --git a/docs/src/test-api/class-testoptions.md b/docs/src/test-api/class-testoptions.md
index 0fba476d73..e8cbfa373c 100644
--- a/docs/src/test-api/class-testoptions.md
+++ b/docs/src/test-api/class-testoptions.md
@@ -556,10 +556,10 @@ export default defineConfig({
Whether to record trace for each test. Defaults to `'off'`.
* `'off'`: Do not record trace.
* `'on'`: Record trace for each test.
-* `'retain-on-failure'`: Record trace for each test, but remove all traces from successful test runs.
* `'on-first-retry'`: Record trace only when retrying a test for the first time.
-* `'on-all-retries'`: Record traces only when retrying for all retries.
-* `'retain-on-first-failure'`: Record traces only when the test fails for the first time.
+* `'on-all-retries'`: Record trace only when retrying a test.
+* `'retain-on-failure'`: Record trace for each test. When test run passes, remove the recorded trace.
+* `'retain-on-first-failure'`: Record trace for the first run of each test, but not for retires. When test run passes, remove the recorded trace.
For more control, pass an object that specifies `mode` and trace features to enable.
diff --git a/packages/playwright-core/src/client/locator.ts b/packages/playwright-core/src/client/locator.ts
index a24286e71e..8fd2d8e088 100644
--- a/packages/playwright-core/src/client/locator.ts
+++ b/packages/playwright-core/src/client/locator.ts
@@ -192,7 +192,7 @@ export class Locator implements api.Locator {
return await this._frame.$$(this._selector);
}
- enterFrame() {
+ contentFrame() {
return new FrameLocator(this._frame, this._selector);
}
@@ -408,7 +408,7 @@ export class FrameLocator implements api.FrameLocator {
return this.locator(getByRoleSelector(role, options));
}
- exitFrame() {
+ owner() {
return new Locator(this._frame, this._frameSelector);
}
diff --git a/packages/playwright-core/types/types.d.ts b/packages/playwright-core/types/types.d.ts
index 235de894cd..3bc56b0a83 100644
--- a/packages/playwright-core/types/types.d.ts
+++ b/packages/playwright-core/types/types.d.ts
@@ -11238,6 +11238,27 @@ export interface Locator {
trial?: boolean;
}): Promise;
+ /**
+ * Returns a {@link FrameLocator} object pointing to the same `iframe` as this locator.
+ *
+ * Useful when you have a {@link Locator} object obtained somewhere, and later on would like to interact with the
+ * content inside the frame.
+ *
+ * For a reverse operation, use
+ * [frameLocator.owner()](https://playwright.dev/docs/api/class-framelocator#frame-locator-owner).
+ *
+ * **Usage**
+ *
+ * ```js
+ * const locator = page.locator('iframe[name="embedded"]');
+ * // ...
+ * const frameLocator = locator.contentFrame();
+ * await frameLocator.getByRole('button').click();
+ * ```
+ *
+ */
+ contentFrame(): FrameLocator;
+
/**
* Returns the number of elements matching the locator.
*
@@ -11462,24 +11483,6 @@ export interface Locator {
*/
elementHandles(): Promise>;
- /**
- * Returns a {@link FrameLocator} object pointing to the same `iframe` as this locator.
- *
- * Useful when you have a {@link Locator} object obtained somewhere, and later on would like to interact with the
- * content inside the frame.
- *
- * **Usage**
- *
- * ```js
- * const locator = page.locator('iframe[name="embedded"]');
- * // ...
- * const frameLocator = locator.enterFrame();
- * await frameLocator.getByRole('button').click();
- * ```
- *
- */
- enterFrame(): FrameLocator;
-
/**
* Set a value to the input field.
*
@@ -13170,9 +13173,10 @@ export interface BrowserType {
deviceScaleFactor?: number;
/**
- * **Chromium-only** Whether to auto-open a Developer Tools panel for each tab. If this option is `true`, the
- * `headless` option will be set `false`.
- * @deprecated Use [debugging tools](https://playwright.dev/docs/debug) instead.
+ * **Deprecated, Chromium-only.** Use [debugging tools](https://playwright.dev/docs/debug) instead.
+ *
+ * Whether to auto-open a Developer Tools panel for each tab. If this option is `true`, the `headless` option will be
+ * set `false`.
*/
devtools?: boolean;
@@ -13575,9 +13579,10 @@ export interface BrowserType {
chromiumSandbox?: boolean;
/**
- * **Chromium-only** Whether to auto-open a Developer Tools panel for each tab. If this option is `true`, the
- * `headless` option will be set `false`.
- * @deprecated Use [debugging tools](https://playwright.dev/docs/debug) instead.
+ * **Deprecated, Chromium-only.** Use [debugging tools](https://playwright.dev/docs/debug) instead.
+ *
+ * Whether to auto-open a Developer Tools panel for each tab. If this option is `true`, the `headless` option will be
+ * set `false`.
*/
devtools?: boolean;
@@ -17783,32 +17788,14 @@ export interface FileChooser {
* **Converting Locator to FrameLocator**
*
* If you have a {@link Locator} object pointing to an `iframe` it can be converted to {@link FrameLocator} using
- * [locator.enterFrame()](https://playwright.dev/docs/api/class-locator#locator-enter-frame).
+ * [locator.contentFrame()](https://playwright.dev/docs/api/class-locator#locator-content-frame).
*
* **Converting FrameLocator to Locator**
*
* If you have a {@link FrameLocator} object it can be converted to {@link Locator} pointing to the same `iframe`
- * using [frameLocator.exitFrame()](https://playwright.dev/docs/api/class-framelocator#frame-locator-exit-frame).
+ * using [frameLocator.owner()](https://playwright.dev/docs/api/class-framelocator#frame-locator-owner).
*/
export interface FrameLocator {
- /**
- * Returns a {@link Locator} object pointing to the same `iframe` as this frame locator.
- *
- * Useful when you have a {@link FrameLocator} object obtained somewhere, and later on would like to interact with the
- * `iframe` element.
- *
- * **Usage**
- *
- * ```js
- * const frameLocator = page.frameLocator('iframe[name="embedded"]');
- * // ...
- * const locator = frameLocator.exitFrame();
- * await expect(locator).toBeVisible();
- * ```
- *
- */
- exitFrame(): Locator;
-
/**
* Returns locator to the first matching frame.
*/
@@ -18190,6 +18177,27 @@ export interface FrameLocator {
* @param index
*/
nth(index: number): FrameLocator;
+
+ /**
+ * Returns a {@link Locator} object pointing to the same `iframe` as this frame locator.
+ *
+ * Useful when you have a {@link FrameLocator} object obtained somewhere, and later on would like to interact with the
+ * `iframe` element.
+ *
+ * For a reverse operation, use
+ * [locator.contentFrame()](https://playwright.dev/docs/api/class-locator#locator-content-frame).
+ *
+ * **Usage**
+ *
+ * ```js
+ * const frameLocator = page.frameLocator('iframe[name="embedded"]');
+ * // ...
+ * const locator = frameLocator.owner();
+ * await expect(locator).toBeVisible();
+ * ```
+ *
+ */
+ owner(): Locator;
}
/**
@@ -20270,9 +20278,10 @@ export interface LaunchOptions {
chromiumSandbox?: boolean;
/**
- * **Chromium-only** Whether to auto-open a Developer Tools panel for each tab. If this option is `true`, the
- * `headless` option will be set `false`.
- * @deprecated Use [debugging tools](https://playwright.dev/docs/debug) instead.
+ * **Deprecated, Chromium-only.** Use [debugging tools](https://playwright.dev/docs/debug) instead.
+ *
+ * Whether to auto-open a Developer Tools panel for each tab. If this option is `true`, the `headless` option will be
+ * set `false`.
*/
devtools?: boolean;
diff --git a/packages/playwright/types/test.d.ts b/packages/playwright/types/test.d.ts
index 497b137774..044c0ba63c 100644
--- a/packages/playwright/types/test.d.ts
+++ b/packages/playwright/types/test.d.ts
@@ -5590,10 +5590,11 @@ export interface PlaywrightWorkerOptions {
* Whether to record trace for each test. Defaults to `'off'`.
* - `'off'`: Do not record trace.
* - `'on'`: Record trace for each test.
- * - `'retain-on-failure'`: Record trace for each test, but remove all traces from successful test runs.
* - `'on-first-retry'`: Record trace only when retrying a test for the first time.
- * - `'on-all-retries'`: Record traces only when retrying for all retries.
- * - `'retain-on-first-failure'`: Record traces only when the test fails for the first time.
+ * - `'on-all-retries'`: Record trace only when retrying a test.
+ * - `'retain-on-failure'`: Record trace for each test. When test run passes, remove the recorded trace.
+ * - `'retain-on-first-failure'`: Record trace for the first run of each test, but not for retires. When test run
+ * passes, remove the recorded trace.
*
* For more control, pass an object that specifies `mode` and trace features to enable.
*
diff --git a/tests/page/locator-frame.spec.ts b/tests/page/locator-frame.spec.ts
index 4b79039ff9..09767331bd 100644
--- a/tests/page/locator-frame.spec.ts
+++ b/tests/page/locator-frame.spec.ts
@@ -299,22 +299,22 @@ it('should work with COEP/COOP/CORP isolated iframe', async ({ page, server, bro
expect(await page.frames()[1].evaluate(() => window['__clicked'])).toBe(true);
});
-it('locator.enterFrame should work', async ({ page, server }) => {
+it('locator.contentFrame should work', async ({ page, server }) => {
await routeIframe(page);
await page.goto(server.EMPTY_PAGE);
const locator = page.locator('iframe');
- const frameLocator = locator.enterFrame();
+ const frameLocator = locator.contentFrame();
const button = frameLocator.locator('button');
expect(await button.innerText()).toBe('Hello iframe');
await expect(button).toHaveText('Hello iframe');
await button.click();
});
-it('frameLocator.exitFrame should work', async ({ page, server }) => {
+it('frameLocator.owner should work', async ({ page, server }) => {
await routeIframe(page);
await page.goto(server.EMPTY_PAGE);
const frameLocator = page.frameLocator('iframe');
- const locator = frameLocator.exitFrame();
+ const locator = frameLocator.owner();
await expect(locator).toBeVisible();
expect(await locator.getAttribute('name')).toBe('frame1');
});
From 82804cce645abd8a419c2273fa9734c299fef612 Mon Sep 17 00:00:00 2001
From: Shriphad Rao
Date: Mon, 25 Mar 2024 21:21:09 +0530
Subject: [PATCH 14/29] fix: time in ms for skip test (#30078)
Fixes https://github.com/microsoft/playwright/issues/29861
---
packages/html-reporter/src/uiUtils.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/packages/html-reporter/src/uiUtils.ts b/packages/html-reporter/src/uiUtils.ts
index 34ad57731f..00022b4204 100644
--- a/packages/html-reporter/src/uiUtils.ts
+++ b/packages/html-reporter/src/uiUtils.ts
@@ -19,7 +19,7 @@ export function msToString(ms: number): string {
return '-';
if (ms === 0)
- return '0';
+ return '0ms';
if (ms < 1000)
return ms.toFixed(0) + 'ms';
From 032f27ff844c3617be2fa9bfb193e8359d8dc9d7 Mon Sep 17 00:00:00 2001
From: Max Schmitt
Date: Mon, 25 Mar 2024 19:17:05 +0100
Subject: [PATCH 15/29] docs: change if: always() to if: !cancelled() (#30102)
Fixes https://github.com/microsoft/playwright/issues/29451
See
https://github.com/microsoft/playwright/issues/29451#issuecomment-2008476721
for investigation.
---
docs/src/ci-intro.md | 4 ++--
docs/src/test-sharding-js.md | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/src/ci-intro.md b/docs/src/ci-intro.md
index f5393cfc9e..561748b6b3 100644
--- a/docs/src/ci-intro.md
+++ b/docs/src/ci-intro.md
@@ -65,7 +65,7 @@ jobs:
- name: Run Playwright tests
run: npx playwright test
- uses: actions/upload-artifact@v4
- if: always()
+ if: ${{ !cancelled() }}
with:
name: playwright-report
path: playwright-report/
@@ -103,7 +103,7 @@ jobs:
- name: Run your tests
run: pytest --tracing=retain-on-failure
- uses: actions/upload-artifact@v4
- if: always()
+ if: ${{ !cancelled() }}
with:
name: playwright-traces
path: test-results/
diff --git a/docs/src/test-sharding-js.md b/docs/src/test-sharding-js.md
index 6738dbeada..8067198b49 100644
--- a/docs/src/test-sharding-js.md
+++ b/docs/src/test-sharding-js.md
@@ -89,7 +89,7 @@ jobs:
run: npx playwright test --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
- name: Upload blob report to GitHub Actions Artifacts
- if: always()
+ if: ${{ !cancelled() }}
uses: actions/upload-artifact@v4
with:
name: blob-report-${{ matrix.shardIndex }}
@@ -104,7 +104,7 @@ jobs:
...
merge-reports:
# Merge reports after playwright-tests, even if some shards have failed
- if: always()
+ if: ${{ !cancelled() }}
needs: [playwright-tests]
runs-on: ubuntu-latest
From f5823786fd7d0a79346fd0d0407d9ac75b2722c3 Mon Sep 17 00:00:00 2001
From: Max Schmitt
Date: Mon, 25 Mar 2024 19:22:15 +0100
Subject: [PATCH 16/29] docs: migrate to newer :::warning syntax (#30089)
- Migrate from `:::warning` to `:::danger[Warning]`.
- Migrate from `:::caution` to `:::warning`.
- `:::warning` and `:::caution` were the color same before.
- `:::caution` is deprecated and gets removed in v4 of Docusaurus
- Also migrate to the [newer title
syntax](https://github.com/facebook/docusaurus/blob/3877c1254f29a64b9f2301775d9ecc2ae5e2a740/packages/docusaurus-utils/src/markdownUtils.ts#L86-L91)
---------
Signed-off-by: Max Schmitt
Co-authored-by: Dmitry Gozman
---
docs/src/accessibility-testing-js.md | 2 +-
docs/src/api/class-elementhandle.md | 2 +-
docs/src/api/class-locator.md | 26 +++++++++++------------
docs/src/api/class-page.md | 2 +-
docs/src/api/params.md | 5 ++---
docs/src/handles.md | 2 +-
docs/src/locators.md | 16 +++++++-------
packages/playwright-core/types/types.d.ts | 21 ++++++++----------
8 files changed, 36 insertions(+), 40 deletions(-)
diff --git a/docs/src/accessibility-testing-js.md b/docs/src/accessibility-testing-js.md
index d367662545..96fe1f1865 100644
--- a/docs/src/accessibility-testing-js.md
+++ b/docs/src/accessibility-testing-js.md
@@ -14,7 +14,7 @@ A few examples of problems this can catch include:
The following examples rely on the [`@axe-core/playwright`](https://npmjs.org/@axe-core/playwright) package which adds support for running the [axe accessibility testing engine](https://www.deque.com/axe/) as part of your Playwright tests.
-:::note Disclaimer
+:::note[Disclaimer]
Automated accessibility tests can detect some common accessibility problems such as missing or invalid properties. But many accessibility problems can only be discovered through manual testing. We recommend using a combination of automated testing, manual accessibility assessments, and inclusive user testing.
For manual assessments, we recommend [Accessibility Insights for Web](https://accessibilityinsights.io/docs/web/overview/?referrer=playwright-accessibility-testing-js), a free and open source dev tool that walks you through assessing a website for [WCAG 2.1 AA](https://www.w3.org/WAI/WCAG21/quickref/?currentsidebar=%23col_customize&levels=aaa) coverage.
diff --git a/docs/src/api/class-elementhandle.md b/docs/src/api/class-elementhandle.md
index 6d727f675a..3f27509a0d 100644
--- a/docs/src/api/class-elementhandle.md
+++ b/docs/src/api/class-elementhandle.md
@@ -4,7 +4,7 @@
ElementHandle represents an in-page DOM element. ElementHandles can be created with the [`method: Page.querySelector`] method.
-:::caution Discouraged
+:::warning[Discouraged]
The use of ElementHandle is discouraged, use [Locator] objects and web-first assertions instead.
:::
diff --git a/docs/src/api/class-locator.md b/docs/src/api/class-locator.md
index 50ef738c9a..9ccfa6c2b1 100644
--- a/docs/src/api/class-locator.md
+++ b/docs/src/api/class-locator.md
@@ -53,7 +53,7 @@ foreach (var li in await page.GetByRole("listitem").AllAsync())
Returns an array of `node.innerText` values for all matching nodes.
-:::caution Asserting text
+:::warning[Asserting text]
If you need to assert text on the page, prefer [`method: LocatorAssertions.toHaveText`] with [`option: useInnerText`] option to avoid flakiness. See [assertions guide](../test-assertions.md) for more details.
:::
@@ -85,7 +85,7 @@ var texts = await page.GetByRole(AriaRole.Link).AllInnerTextsAsync();
Returns an array of `node.textContent` values for all matching nodes.
-:::caution Asserting text
+:::warning[Asserting text]
If you need to assert text on the page, prefer [`method: LocatorAssertions.toHaveText`] to avoid flakiness. See [assertions guide](../test-assertions.md) for more details.
:::
@@ -443,7 +443,7 @@ await page.Locator("canvas").ClickAsync(new() {
Returns the number of elements matching the locator.
-:::caution Asserting count
+:::warning[Asserting count]
If you need to assert the number of elements on the page, prefer [`method: LocatorAssertions.toHaveCount`] to avoid flakiness. See [assertions guide](../test-assertions.md) for more details.
:::
@@ -1121,7 +1121,7 @@ await locator.ClickAsync();
Returns the matching element's attribute value.
-:::caution Asserting attributes
+:::warning[Asserting attributes]
If you need to assert an element's attribute, prefer [`method: LocatorAssertions.toHaveAttribute`] to avoid flakiness. See [assertions guide](../test-assertions.md) for more details.
:::
@@ -1293,7 +1293,7 @@ Returns the [`element.innerHTML`](https://developer.mozilla.org/en-US/docs/Web/A
Returns the [`element.innerText`](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/innerText).
-:::caution Asserting text
+:::warning[Asserting text]
If you need to assert text on the page, prefer [`method: LocatorAssertions.toHaveText`] with [`option: useInnerText`] option to avoid flakiness. See [assertions guide](../test-assertions.md) for more details.
:::
@@ -1309,7 +1309,7 @@ If you need to assert text on the page, prefer [`method: LocatorAssertions.toHav
Returns the value for the matching `` or `