From 118333ad37162a9918d9ccdb39f6b07823ea2ca1 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Tue, 7 Apr 2020 16:21:31 -0700
Subject: [PATCH] test: fix event coverage on Chromium (#1693)

Chromium events were mistakenly attributed to Firefox.
---
 test/playwright.spec.js | 44 ++++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/test/playwright.spec.js b/test/playwright.spec.js
index 7bf9c2362f..c0a5a0ad28 100644
--- a/test/playwright.spec.js
+++ b/test/playwright.spec.js
@@ -23,28 +23,6 @@ const {TestServer} = require('../utils/testserver/');
 const YELLOW_COLOR = '\x1b[33m';
 const RESET_COLOR = '\x1b[0m';
 
-const BROWSER_CONFIGS = [
-  {
-    name: 'Firefox',
-    events: {
-      ...require('../lib/events').Events,
-      ...require('../lib/chromium/events').Events,
-    },
-    missingCoverage: ['browserContext.setGeolocation', 'browserContext.setOffline', 'cDPSession.send', 'cDPSession.detach'],
-  },
-  {
-    name: 'WebKit',
-    events: require('../lib/events').Events,
-    missingCoverage: ['browserContext.clearPermissions', 'cDPSession.send', 'cDPSession.detach'],
-  },
-  {
-    name: 'Chromium',
-    events: require('../lib/events').Events,
-    missingCoverage: [],
-  },
-];
-const browserNames = BROWSER_CONFIGS.map(config => config.name);
-
 /**
  * @type {TestSuite}
  */
@@ -265,6 +243,28 @@ module.exports.addPlaywrightTests = ({platform, products, playwrightPath, headle
       });
 
       if (coverage) {
+        const BROWSER_CONFIGS = [
+          {
+            name: 'Firefox',
+            events: require('../lib/events').Events,
+            missingCoverage: ['browserContext.setGeolocation', 'browserContext.setOffline', 'cDPSession.send', 'cDPSession.detach'],
+          },
+          {
+            name: 'WebKit',
+            events: require('../lib/events').Events,
+            missingCoverage: ['browserContext.clearPermissions', 'cDPSession.send', 'cDPSession.detach'],
+          },
+          {
+            name: 'Chromium',
+            events: {
+              ...require('../lib/events').Events,
+              ...require('../lib/chromium/events').Events,
+            },
+            // Sometimes we already have a background page while launching, before adding a listener.
+            missingCoverage: ['chromiumBrowserContext.emit("backgroundpage")'],
+          },
+        ];
+        const browserNames = BROWSER_CONFIGS.map(config => config.name);
         const browserConfig = BROWSER_CONFIGS.find(config => config.name === product);
         const api = require('../lib/api');
         const filteredApi = {};