Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: do not use docker for "Web Components" tests (#20339)

Browse source
This commit is contained in:
Dmitry Gozman 2023-01-24 14:00:10 -08:00 committed by GitHub
parent 1f576ff0bc
commit 1196b4f0f5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 1 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
.github/workflows/tests_primary.yml vendored
View file

@ -144,14 +144,7 @@ jobs:
DEBUG: pw:install DEBUG: pw:install
- run: npm run build - run: npm run build
- run: npx playwright install --with-deps - run: npx playwright install --with-deps
- run: | - run: xvfb-run npm run test-html-reporter
./utils/docker/build.sh --amd64 focal $PWTEST_DOCKER_BASE_IMAGE
npx playwright docker build
nohup npx playwright docker start &
xvfb-run npm run test-html-reporter
env:
PLAYWRIGHT_DOCKER: 1
PWTEST_DOCKER_BASE_IMAGE: playwright:localbuild
- run: xvfb-run npm run test-web - run: xvfb-run npm run test-web
if: always() if: always()

1
packages/html-reporter/playwright.config.ts
View file

@ -20,7 +20,6 @@ export default defineConfig({
testDir: 'src', testDir: 'src',
forbidOnly: !!process.env.CI, forbidOnly: !!process.env.CI,
retries: process.env.CI ? 2 : 0, retries: process.env.CI ? 2 : 0,
ignoreSnapshots: !process.env.PLAYWRIGHT_DOCKER,
snapshotPathTemplate: '{testDir}/__screenshots__/{projectName}/{testFilePath}/{arg}{ext}', snapshotPathTemplate: '{testDir}/__screenshots__/{projectName}/{testFilePath}/{arg}{ext}',
reporter: 'html', reporter: 'html',
use: { use: {

BIN
packages/html-reporter/src/__screenshots__/chromium/chip.spec.tsx/expand-collapse-1.png
View file

Binary file not shown.
Side by side

Before

Width:  |  Height:  |  Size: 2.5 KiB

BIN
packages/html-reporter/src/__screenshots__/chromium/chip.spec.tsx/render-long-title-1.png
View file

Binary file not shown.
Side by side

Before

Width:  |  Height:  |  Size: 5.7 KiB

2
packages/html-reporter/src/chip.spec.tsx
View file

@ -28,7 +28,6 @@ test('expand collapse', async ({ mount }) => {
await expect(component.getByText('Chip body')).not.toBeVisible(); await expect(component.getByText('Chip body')).not.toBeVisible();
await component.getByText('Title').click(); await component.getByText('Title').click();
await expect(component.getByText('Chip body')).toBeVisible(); await expect(component.getByText('Chip body')).toBeVisible();
await expect(component).toHaveScreenshot();
}); });
test('render long title', async ({ mount }) => { test('render long title', async ({ mount }) => {
@ -38,7 +37,6 @@ test('render long title', async ({ mount }) => {
</AutoChip>); </AutoChip>);
await expect(component).toContainText('Extremely long title.'); await expect(component).toContainText('Extremely long title.');
await expect(component.getByText('Extremely long title.')).toHaveAttribute('title', title); await expect(component.getByText('Extremely long title.')).toHaveAttribute('title', title);
await expect(component).toHaveScreenshot();
}); });
test('setExpanded is called', async ({ mount }) => { test('setExpanded is called', async ({ mount }) => {