From 12104c395f3707c41007194f98ac5a5208342200 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Wed, 11 Dec 2024 18:04:30 -0800 Subject: [PATCH] add comment --- packages/playwright-core/src/server/chromium/crPage.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/playwright-core/src/server/chromium/crPage.ts b/packages/playwright-core/src/server/chromium/crPage.ts index 1048d23dba..a7ee34d2c5 100644 --- a/packages/playwright-core/src/server/chromium/crPage.ts +++ b/packages/playwright-core/src/server/chromium/crPage.ts @@ -432,6 +432,8 @@ class FrameSession { this._firstNonInitialNavigationCommittedFulfill = f; this._firstNonInitialNavigationCommittedReject = r; }); + // The Promise is not always awaited (e.g. FrameSession._initialize can throw) + // so we catch errors here to prevent unhandled promise rejection. this._firstNonInitialNavigationCommittedPromise.catch(() => {}); }