From 13762c82f9f9a58ce209c7062f53981c49f92026 Mon Sep 17 00:00:00 2001
From: Pavel Feldman <pavel.feldman@gmail.com>
Date: Wed, 8 Jun 2022 17:21:19 -0800
Subject: [PATCH] tests: nuke the failing/flaky test (#14724)

---
 tests/library/defaultbrowsercontext-2.spec.ts | 30 -------------------
 tests/page/page-click.spec.ts                 |  4 +--
 tests/page/page-network-response.spec.ts      |  3 +-
 tests/page/page-set-input-files.spec.ts       |  2 +-
 4 files changed, 5 insertions(+), 34 deletions(-)

diff --git a/tests/library/defaultbrowsercontext-2.spec.ts b/tests/library/defaultbrowsercontext-2.spec.ts
index 170e6d2989..e109309b8e 100644
--- a/tests/library/defaultbrowsercontext-2.spec.ts
+++ b/tests/library/defaultbrowsercontext-2.spec.ts
@@ -128,36 +128,6 @@ it('should create userDataDir if it does not exist', async ({ createUserDataDir,
   expect(fs.readdirSync(userDataDir).length).toBeGreaterThan(0);
 });
 
-it('should restore cookies from userDataDir', async ({ browserType, server, createUserDataDir, platform, channel, browserName, headless }) => {
-  it.fixme(browserName === 'firefox' && !headless, 'https://github.com/microsoft/playwright/issues/12632');
-  it.fixme(platform === 'win32' && channel === 'chrome');
-  it.slow();
-
-  const userDataDir = await createUserDataDir();
-  const browserContext = await browserType.launchPersistentContext(userDataDir);
-  const page = await browserContext.newPage();
-  await page.goto(server.EMPTY_PAGE);
-  const documentCookie = await page.evaluate(() => {
-    document.cookie = 'doSomethingOnlyOnce=true; expires=Fri, 31 Dec 9999 23:59:59 GMT';
-    return document.cookie;
-  });
-  expect(documentCookie).toBe('doSomethingOnlyOnce=true');
-  await browserContext.close();
-
-  const browserContext2 = await browserType.launchPersistentContext(userDataDir);
-  const page2 = await browserContext2.newPage();
-  await page2.goto(server.EMPTY_PAGE);
-  expect(await page2.evaluate(() => document.cookie)).toBe('doSomethingOnlyOnce=true');
-  await browserContext2.close();
-
-  const userDataDir2 = await createUserDataDir();
-  const browserContext3 = await browserType.launchPersistentContext(userDataDir2);
-  const page3 = await browserContext3.newPage();
-  await page3.goto(server.EMPTY_PAGE);
-  expect(await page3.evaluate(() => document.cookie)).not.toBe('doSomethingOnlyOnce=true');
-  await browserContext3.close();
-});
-
 it('should have default URL when launching browser', async ({ launchPersistent }) => {
   const { context } = await launchPersistent();
   const urls = context.pages().map(page => page.url());
diff --git a/tests/page/page-click.spec.ts b/tests/page/page-click.spec.ts
index 10421078c1..6ab07bfc3c 100644
--- a/tests/page/page-click.spec.ts
+++ b/tests/page/page-click.spec.ts
@@ -832,8 +832,8 @@ it('should not throw protocol error when navigating during the click', async ({
   expect(await page.evaluate('result')).toBe('Clicked');
 });
 
-it('should retry when navigating during the click', async ({ page, server, mode }) => {
-  it.skip(mode !== 'default');
+it('should retry when navigating during the click', async ({ page, server, mode, isAndroid }) => {
+  it.skip(mode !== 'default' || isAndroid);
 
   await page.goto(server.PREFIX + '/input/button.html');
   let firstTime = true;
diff --git a/tests/page/page-network-response.spec.ts b/tests/page/page-network-response.spec.ts
index 25b1fe83a2..db385b4b9f 100644
--- a/tests/page/page-network-response.spec.ts
+++ b/tests/page/page-network-response.spec.ts
@@ -319,7 +319,8 @@ it('should return headers after route.fulfill', async ({ page, server }) => {
   });
 });
 
-it('should report if request was fromServiceWorker', async ({ page, server }) => {
+it('should report if request was fromServiceWorker', async ({ page, server, isAndroid }) => {
+  it.skip(isAndroid);
   {
     const res = await page.goto(server.PREFIX + '/serviceworkers/fetch/sw.html');
     expect(res.fromServiceWorker()).toBe(false);
diff --git a/tests/page/page-set-input-files.spec.ts b/tests/page/page-set-input-files.spec.ts
index 41dfad97a2..328109c4fb 100644
--- a/tests/page/page-set-input-files.spec.ts
+++ b/tests/page/page-set-input-files.spec.ts
@@ -519,7 +519,7 @@ it('should emit event after navigation', async ({ page, server, browserName, bro
 });
 
 it('should trigger listener added before navigation', async ({ page, server , browserMajorVersion, isElectron }) => {
-  it.skip(isElectron && browserMajorVersion <= 17);
+  it.skip(isElectron || browserMajorVersion <= 17);
   // Add listener before cross process navigation.
   const chooserPromise = new Promise(f => page.once('filechooser', f));
   await page.goto(server.PREFIX + '/empty.html');