Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

don't swallow the first error if the second throws

Browse source
This commit is contained in:
Simon Knott 2024-10-18 08:58:22 +02:00
parent 9b785662f6
commit 13a4d19764
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/playwright/src/runner/tasks.ts
View file

@ -182,15 +182,18 @@ function createGlobalSetupTask(index: number, length: number): Task<TestRun> {
globalSetupFinished = true; globalSetupFinished = true;
}, },
teardown: async ({ config }) => { teardown: async ({ config }) => {
let firstError: any; const errors = [];
if (typeof globalSetupResult === 'function') if (typeof globalSetupResult === 'function')
try { await globalSetupResult(); } catch (error) { firstError = error; } try { await globalSetupResult(); } catch (error) { errors.push(error); }
if (globalSetupFinished) if (globalSetupFinished)
await teardownHook?.(config.config); try { await teardownHook?.(config.config); } catch (error) { errors.push(error); }
if (firstError) if (errors.length === 1)
throw firstError; throw errors[0];
if (errors.length > 1)
throw new AggregateError(errors);
}, },
}; };
} }