From 13dd41c2e36a63f35ddef5dc5dec322052d670c6 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Tue, 4 Jan 2022 07:23:28 -0700 Subject: [PATCH] devops: fix self-hosted runner stack collection (#11169) In case of self-hosted github runners, it's much easier to checkout under `playwright-internal` folder name instead of a default `playwright` name. This confuses our stack collection. This patch makes it generic. --- packages/playwright-core/src/utils/stackTrace.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/playwright-core/src/utils/stackTrace.ts b/packages/playwright-core/src/utils/stackTrace.ts index fc90f4db67..a0e1036176 100644 --- a/packages/playwright-core/src/utils/stackTrace.ts +++ b/packages/playwright-core/src/utils/stackTrace.ts @@ -37,6 +37,7 @@ const UTIL_LIB = path.join(CORE_DIR, 'lib', 'util'); const UTIL_SRC = path.join(CORE_DIR, 'src', 'util'); const TEST_DIR_SRC = path.resolve(CORE_DIR, '..', 'playwright-test'); const TEST_DIR_LIB = path.resolve(CORE_DIR, '..', '@playwright', 'test'); +const COVERAGE_PATH = path.join(CORE_DIR, '..', '..', 'tests', 'config', 'coverage.js'); const WS_LIB = path.relative(process.cwd(), path.dirname(require.resolve('ws'))); export type ParsedStackTrace = { @@ -85,7 +86,7 @@ export function captureStackTrace(rawStack?: string): ParsedStackTrace { fileName = new URL(frame.file).pathname; else fileName = path.resolve(process.cwd(), frame.file); - if (isTesting && fileName.includes(path.join('playwright', 'tests', 'config', 'coverage.js'))) + if (isTesting && fileName.includes(COVERAGE_PATH)) return null; const inClient = fileName.startsWith(CLIENT_LIB) || fileName.startsWith(CLIENT_SRC) || fileName.startsWith(UTIL_LIB) || fileName.startsWith(UTIL_SRC); const parsed: ParsedFrame = {