Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

browser(firefox): a11y haspopup is a string, not a boolean (#15056)

Browse source
This commit is contained in:
Dmitry Gozman 2022-06-22 17:01:13 -07:00 committed by GitHub
parent 7bd72716f9
commit 141093a1cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
browser_patches/firefox-beta/BUILD_NUMBER
View file

@ -1,2 +1,2 @@
1329 1330
Changed: dgozman@gmail.com Thu Jun 2 16:19:39 PDT 2022 Changed: dgozman@gmail.com Wed Jun 22 16:26:54 PDT 2022

3
browser_patches/firefox-beta/juggler/content/PageAgent.js
View file

@ -869,7 +869,6 @@ class PageAgent {
'focused', 'focused',
'pressed', 'pressed',
'focusable', 'focusable',
'haspopup',
'required', 'required',
'invalid', 'invalid',
'modal', 'modal',
@ -906,7 +905,7 @@ class PageAgent {
if (numericalProperty in attributes) if (numericalProperty in attributes)
tree[numericalProperty] = parseFloat(attributes[numericalProperty]); tree[numericalProperty] = parseFloat(attributes[numericalProperty]);
} }
for (const stringProperty of ['tag', 'roledescription', 'valuetext', 'orientation', 'autocomplete', 'keyshortcuts']) { for (const stringProperty of ['tag', 'roledescription', 'valuetext', 'orientation', 'autocomplete', 'keyshortcuts', 'haspopup']) {
if (stringProperty in attributes) if (stringProperty in attributes)
tree[stringProperty] = attributes[stringProperty]; tree[stringProperty] = attributes[stringProperty];
} }

2
browser_patches/firefox-beta/juggler/protocol/Protocol.js
View file

@ -149,7 +149,7 @@ axTypes.AXTree = {
focused: t.Optional(t.Boolean), focused: t.Optional(t.Boolean),
pressed: t.Optional(t.Boolean), pressed: t.Optional(t.Boolean),
focusable: t.Optional(t.Boolean), focusable: t.Optional(t.Boolean),
haspopup: t.Optional(t.Boolean), haspopup: t.Optional(t.String),
required: t.Optional(t.Boolean), required: t.Optional(t.Boolean),
invalid: t.Optional(t.Boolean), invalid: t.Optional(t.Boolean),
modal: t.Optional(t.Boolean), modal: t.Optional(t.Boolean),

4
browser_patches/firefox/BUILD_NUMBER
View file

@ -1,2 +1,2 @@
1327 1328
Changed: dgozman@gmail.com Thu Jun 2 16:19:39 PDT 2022 Changed: dgozman@gmail.com Wed Jun 22 16:26:54 PDT 2022

3
browser_patches/firefox/juggler/content/PageAgent.js
View file

@ -869,7 +869,6 @@ class PageAgent {
'focused', 'focused',
'pressed', 'pressed',
'focusable', 'focusable',
'haspopup',
'required', 'required',
'invalid', 'invalid',
'modal', 'modal',
@ -906,7 +905,7 @@ class PageAgent {
if (numericalProperty in attributes) if (numericalProperty in attributes)
tree[numericalProperty] = parseFloat(attributes[numericalProperty]); tree[numericalProperty] = parseFloat(attributes[numericalProperty]);
} }
for (const stringProperty of ['tag', 'roledescription', 'valuetext', 'orientation', 'autocomplete', 'keyshortcuts']) { for (const stringProperty of ['tag', 'roledescription', 'valuetext', 'orientation', 'autocomplete', 'keyshortcuts', 'haspopup']) {
if (stringProperty in attributes) if (stringProperty in attributes)
tree[stringProperty] = attributes[stringProperty]; tree[stringProperty] = attributes[stringProperty];
} }

2
browser_patches/firefox/juggler/protocol/Protocol.js
View file

@ -149,7 +149,7 @@ axTypes.AXTree = {
focused: t.Optional(t.Boolean), focused: t.Optional(t.Boolean),
pressed: t.Optional(t.Boolean), pressed: t.Optional(t.Boolean),
focusable: t.Optional(t.Boolean), focusable: t.Optional(t.Boolean),
haspopup: t.Optional(t.Boolean), haspopup: t.Optional(t.String),
required: t.Optional(t.Boolean), required: t.Optional(t.Boolean),
invalid: t.Optional(t.Boolean), invalid: t.Optional(t.Boolean),
modal: t.Optional(t.Boolean), modal: t.Optional(t.Boolean),