Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: do not recommend yarn (#794)

Browse source 
There's some confusion around Yarn vs Yarn 2 and their interop, which
apparently causes some [installation issues](https://stackoverflow.com/questions/59918776/playwright-error-firefox-revision-is-not-downloaded-run-npm-install-or-yarn)
This commit is contained in:
Andrey Lushnikov 2020-01-31 17:23:39 -08:00 committed by GitHub
parent b8199c0813
commit 1489fbdbff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/server/chromium.ts
View file

@ -248,7 +248,7 @@ export class Chromium implements BrowserType {
_resolveExecutablePath(): { executablePath: string; missingText: string | null; } {
const browserFetcher = this._createBrowserFetcher();
const revisionInfo = browserFetcher.revisionInfo();
const missingText = !revisionInfo.local ? `Chromium revision is not downloaded. Run "npm install" or "yarn install"` : null;
const missingText = !revisionInfo.local ? `Chromium revision is not downloaded. Run "npm install"` : null;
return { executablePath: revisionInfo.executablePath, missingText };
}
}

2
src/server/firefox.ts
View file

@ -227,7 +227,7 @@ export class Firefox implements BrowserType {
_resolveExecutablePath() {
const browserFetcher = this._createBrowserFetcher();
const revisionInfo = browserFetcher.revisionInfo();
const missingText = !revisionInfo.local ? `Firefox revision is not downloaded. Run "npm install" or "yarn install"` : null;
const missingText = !revisionInfo.local ? `Firefox revision is not downloaded. Run "npm install"` : null;
return { executablePath: revisionInfo.executablePath, missingText };
}
}

2
src/server/webkit.ts
View file

@ -218,7 +218,7 @@ export class WebKit implements BrowserType {
_resolveExecutablePath(): { executablePath: string; missingText: string | null; } {
const browserFetcher = this._createBrowserFetcher();
const revisionInfo = browserFetcher.revisionInfo();
const missingText = !revisionInfo.local ? `WebKit revision is not downloaded. Run "npm install" or "yarn install"` : null;
const missingText = !revisionInfo.local ? `WebKit revision is not downloaded. Run "npm install"` : null;
return { executablePath: revisionInfo.executablePath, missingText };
}
}